[optim][adadelta] default to foreach when CUDA + differentiable=False #91896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91896
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e3e7a3e: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
janeyx99
added
release notes: nn
lezcano
reviewed
Jan 10, 2023
janeyx99
force-pushed
the
adadelta-foreach
branch
from
f7f29c2
to
6c6815e
Compare
|
Did not mean to make this ready for review--this has extra commits that have not landed yet |
janeyx99
force-pushed
the
adadelta-foreach
branch
2 times, most recently
from
86b9b51
to
a374f19
Compare
janeyx99
force-pushed
the
adadelta-foreach
branch
from
a374f19
to
e3e7a3e
Compare
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following up to #90865 and #92048