Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[functorch] vmap: bitwise operators #91971

Closed
wants to merge 11 commits into from
Closed

[functorch] vmap: bitwise operators #91971

wants to merge 11 commits into from

Conversation

khushi-411
Copy link
Contributor

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 10, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91971

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit 8058058:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@khushi-411 khushi-411 marked this pull request as ready for review January 14, 2023 15:51
@khushi-411
Copy link
Contributor Author

cc @zou3519 @kshitij12345

kshitij12345
kshitij12345 requested changes Jan 17, 2023
View reviewed changes
Copy link
Collaborator

@kshitij12345 kshitij12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some overloads are missing as you haven't removed the following xfails and CI is green.

pytorch/test/functorch/test_vmap.py

Lines 3711 to 3713 in bbce418

xfail('bitwise_and'),
xfail('bitwise_or'),
xfail('bitwise_xor'),

@bdhirsh bdhirsh added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jan 18, 2023
Chillee
Chillee approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@Chillee Chillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kshitij12345
kshitij12345 approved these changes Jan 23, 2023
View reviewed changes
Copy link
Collaborator

@kshitij12345 kshitij12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @khushi-411

@khushi-411
Copy link
Contributor Author

Thanks for your help and reviews, @kshitij12345 and @Chillee!! :)

@pytorchmergebot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 23, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@khushi-411 khushi-411 deleted the vmap_bitwise branch January 23, 2023 10:15
@malfet
Copy link
Contributor

malfet commented Jan 23, 2023

@pytorchbot revert -m "Broke functorch bitwise, see https://hud.pytorch.org/pytorch/pytorch/commit/e54f7b3edde356c97c99706942f4b32a5a5ba475" -c weird

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

Reverting PR 91971 failed

Reason: Comment with id 1400474347 not found

Details for Dev Infra team Raised by workflow job

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

@khushi-411 your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Jan 23, 2023
@pytorchmergebot
Revert "[functorch] vmap: bitwise operators (#91971)"
7ddcf4e 
This reverts commit e54f7b3.

Reverted #91971 on behalf of https://github.com/malfet due to Broke functorch bitwise, see https://hud.pytorch.org/pytorch/pytorch/commit/e54f7b3edde356c97c99706942f4b32a5a5ba475
@khushi-411 khushi-411 mentioned this pull request Jan 23, 2023
Closed
pytorchmergebot pushed a commit that referenced this pull request Jan 26, 2023
@khushi-411 @pytorchmergebot
[functorch][reland] vmap: bitwise operators (#92836)
4c074dd 
Previous PR: #91971

Fixes: pytorch/functorch#1069

Pull Request resolved: #92836
Approved by: https://github.com/Chillee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chillee Chillee Chillee approved these changes

@kshitij12345 kshitij12345 kshitij12345 approved these changes

@zou3519 zou3519 Awaiting requested review from zou3519

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source Reverted triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Performance drop because of not yet implemented batching rule.
7 participants
@khushi-411 @pytorchmergebot @malfet @Chillee @kshitij12345 @bdhirsh @pytorchbot