Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Quant][docs] Move parts of BackendConfig tutorial #91999

Closed
wants to merge 3 commits into from

Conversation

andrewor14
Copy link
Contributor

@andrewor14 andrewor14 commented Jan 11, 2023

Stack from ghstack (oldest at bottom):

Summary: This commit moves the API specification section of
the BackendConfig tutorial to the docstrings, which is a more
suitable place for this content. This change also reduces some
duplication. There is no new content added in this change.

Reviewers: jerryzh168, vkuzo

Subscribers: jerryzh168, vkuzo

Summary: This commit moves the API specification section of
the BackendConfig tutorial to the docstrings. There is no
new content added in this change.

Reviewers: jerryzh168, vkuzo

Subscribers: jerryzh168, vkuzo

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 11, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91999

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8a62e19:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

andrewor14 added a commit that referenced this pull request Jan 11, 2023
Summary: This commit moves the API specification section of
the BackendConfig tutorial to the docstrings. There is no
new content added in this change.

Reviewers: jerryzh168, vkuzo

Subscribers: jerryzh168, vkuzo

ghstack-source-id: 50e1bc189d628b544776f387b9ede7de3c258e48
Pull Request resolved: #91999
@github-actions github-actions bot added the release notes: quantization release notes category label Jan 11, 2023
andrewor14 added a commit to andrewor14/tutorials that referenced this pull request Jan 11, 2023
Summary: This commit moves the API specification to the docstrings.
See pytorch/pytorch#91999,

Reviewers: jerryzh168, vkuzo

Subscribers: jerryzh168, vkuzo
Summary: This commit moves the API specification section of
the BackendConfig tutorial to the docstrings, which is a more
suitable place for this content. This change also reduces some
duplication. There is no new content added in this change.

Reviewers: jerryzh168, vkuzo

Subscribers: jerryzh168, vkuzo

[ghstack-poisoned]
andrewor14 added a commit that referenced this pull request Jan 11, 2023
Summary: This commit moves the API specification section of
the BackendConfig tutorial to the docstrings, which is a more
suitable place for this content. This change also reduces some
duplication. There is no new content added in this change.

Reviewers: jerryzh168, vkuzo

Subscribers: jerryzh168, vkuzo

ghstack-source-id: 50e1bc189d628b544776f387b9ede7de3c258e48
Pull Request resolved: #91999
@andrewor14
Copy link
Contributor Author

Please also review: pytorch/tutorials#2169

Copy link
Contributor

@jerryzh168 jerryzh168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@jerryzh168
Copy link
Contributor

I think we can move Data Type Restrictions section from tutorial to the docstring of DTypeWithConstraints as well

Summary: This commit moves the API specification section of
the BackendConfig tutorial to the docstrings, which is a more
suitable place for this content. This change also reduces some
duplication. There is no new content added in this change.

Reviewers: jerryzh168, vkuzo

Subscribers: jerryzh168, vkuzo

[ghstack-poisoned]
andrewor14 added a commit that referenced this pull request Jan 12, 2023
Summary: This commit moves the API specification and Data
Type Restriction sections of the BackendConfig tutorial to
the docstrings, which is a more suitable place for this content.
This change also reduces some duplication. There is no new
content added in this change.

Reviewers: jerryzh168, vkuzo

Subscribers: jerryzh168, vkuzo

ghstack-source-id: 891815fc572e9f7d48bb65a8d328d821e484ef24
Pull Request resolved: #91999
@andrewor14 andrewor14 changed the title [Quant][docs] Move BackendConfig API specification [Quant][docs] Move parts of BackendConfig tutorial Jan 12, 2023
@andrewor14
Copy link
Contributor Author

andrewor14 commented Jan 12, 2023

@jerryzh168 Ok, I ended up moving parts of "Data Type Restriction" to the docstrings of DTypeConfig and DTypeWithConstraints, since only the last part of that section referred to the constraints specifically

andrewor14 added a commit to andrewor14/tutorials that referenced this pull request Jan 12, 2023
Summary: This commit moves the API specification to the docstrings.
See pytorch/pytorch#91999,

Reviewers: jerryzh168, vkuzo

Subscribers: jerryzh168, vkuzo
andrewor14 added a commit to andrewor14/tutorials that referenced this pull request Jan 12, 2023
Summary: This commit moves the API specification and the Data
Type Restriction sections to the docstrings. See
pytorch/pytorch#91999. This commit also
divides the end-to-end example into sections to make it easier
to follow.

Reviewers: jerryzh168, vkuzo

Subscribers: jerryzh168, vkuzo
andrewor14 added a commit to andrewor14/tutorials that referenced this pull request Jan 12, 2023
Summary: This commit moves the API specification and the Data
Type Restriction sections to the docstrings. See
pytorch/pytorch#91999. This commit also
reorganizes the end-to-end example to make it easier to follow.

Reviewers: jerryzh168, vkuzo

Subscribers: jerryzh168, vkuzo
andrewor14 added a commit to andrewor14/tutorials that referenced this pull request Jan 12, 2023
Summary: This commit moves the API specification and the Data
Type Restriction sections to the docstrings. See
pytorch/pytorch#91999. This commit also
reorganizes the end-to-end example to make it easier to follow.

Reviewers: jerryzh168, vkuzo

Subscribers: jerryzh168, vkuzo
andrewor14 added a commit to andrewor14/tutorials that referenced this pull request Jan 13, 2023
Summary: This commit moves the API specification and the Data
Type Restriction sections to the docstrings. See
pytorch/pytorch#91999. This commit also
reorganizes the end-to-end example to make it easier to follow.

Reviewers: jerryzh168, vkuzo

Subscribers: jerryzh168, vkuzo
@andrewor14
Copy link
Contributor Author

@pytorchbot merge -g

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 13, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

svekars pushed a commit to pytorch/tutorials that referenced this pull request Jan 18, 2023
Summary: This commit moves the API specification and the Data
Type Restriction sections to the docstrings. See
pytorch/pytorch#91999. This commit also
reorganizes the end-to-end example to make it easier to follow.

Reviewers: jerryzh168, vkuzo

Subscribers: jerryzh168, vkuzo
@facebook-github-bot facebook-github-bot deleted the gh/andrewor14/42/head branch June 8, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: AO frontend release notes: quantization release notes category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants