Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sparse_mask: remove redundant mask.coalesce() in to_dense_backward #92001

Closed
wants to merge 7 commits into from

Conversation

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 11, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92001

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b06fd63:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

cc alexsamardzic pearu cpuhrsch amjames bhosmer

[ghstack-poisoned]
cc alexsamardzic pearu cpuhrsch amjames bhosmer

[ghstack-poisoned]
@nikitaved nikitaved changed the title sparse_mask: remove redundant mask.coalesce() sparse_mask: remove redundant mask.coalesce() in to_dense_backward Jan 11, 2023
@nikitaved nikitaved requested review from pearu, amjames, bhosmer and cpuhrsch and removed request for amjames January 11, 2023 13:27
@nikitaved nikitaved marked this pull request as ready for review January 11, 2023 13:27
…backward"

cc alexsamardzic pearu cpuhrsch amjames bhosmer

[ghstack-poisoned]
…backward"

cc alexsamardzic pearu cpuhrsch amjames bhosmer

[ghstack-poisoned]
Copy link
Contributor

@cpuhrsch cpuhrsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

…backward"

cc alexsamardzic pearu cpuhrsch amjames bhosmer

[ghstack-poisoned]
…backward"

cc alexsamardzic pearu cpuhrsch amjames bhosmer

[ghstack-poisoned]
@cpuhrsch
Copy link
Contributor

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/nikitaved/13/head branch June 8, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: sparse Related to torch.sparse open source release notes: sparse release notes category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants