Fix Vulkan compiling issues on Windows #92207
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92207
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 28f6eab: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
mantaionut
force-pushed
the
fix_Vulkan_Windows
branch
2 times, most recently
from
407fbe9
to
6a8efb4
Compare
|
@malfet can you please review these changes? |
| binder.resource_info.buffer_info.buffer = buffer.handle(); // buffer | ||
| binder.resource_info.buffer_info.offset = buffer.mem_offset(); // offset | ||
| binder.resource_info.buffer_info.range = buffer.mem_range(); // range | ||
| add_binding(binder); |
ezyang
added
triaged
|
this looks plausible but I'm deferring to vulkan expert |
mantaionut
force-pushed
the
fix_Vulkan_Windows
branch
2 times, most recently
from
50f9e73
to
fc3a760
Compare
|
@ezyang I made the change you requested. Do you know who can review my changes? |
| @@ -234,12 +234,14 @@ template < | |||
| typename T, | |||
| typename FindKey, | |||
| typename ArgumentHash, | |||
| typename Hasher, | |||
| typename DetailHasher, | |||
There was a problem hiding this comment.
Is this change necessary? Seems that it's simply changing the name of Hasher to DetailHasher. I believe this file was copied over from this repo so I think we should avoid making changes unless necessary.
There was a problem hiding this comment.
It's mentioned in PR description, isn't it
Rename Hasher typename since it's not compiling due to https://developercommunity.visualstudio.com/t/1397858
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: This PR is too stale; the last push date was more than 3 days ago. Please rebase and try again. You can rebase by leaving the following comment on this PR: Details for Dev Infra teamRaised by workflow job |
Change designated initializers since they require c++20. Rename Hasher typename since it's not compiling due to https://developercommunity.visualstudio.com/t/1397858
mantaionut
force-pushed
the
fix_Vulkan_Windows
branch
from
fc3a760
to
28f6eab
Compare
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
PR based on #61431
Fix USE_VULKAN=1 and USE_VULKAN_WRAPPER=0 not compiling on Windows.
Change designated initializers since they require C++20.
Rename Hasher typename since it's not compiling due to https://developercommunity.visualstudio.com/t/1397858
Fixes #59519