Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[optim][adam] group tensors in foreach to maximize perf #92349

Closed
wants to merge 1 commit into from
Closed

[optim][adam] group tensors in foreach to maximize perf #92349

wants to merge 1 commit into from

Conversation

janeyx99
Copy link
Contributor

@janeyx99 janeyx99 commented Jan 17, 2023 •
edited

same idea as #92338

@janeyx99 janeyx99 requested a review from albanD as a code owner January 17, 2023 23:39
@pytorch-bot pytorch-bot bot added the release notes: nn release notes category label Jan 17, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 17, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92349

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit 5f91e70:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@janeyx99 janeyx99 added topic: performance topic category ciflow/trunk Trigger trunk jobs on your pull request labels Jan 17, 2023
@janeyx99
Copy link
Contributor Author

@pytorchbot merge -f "parallelnative failure is flaky already disabled test"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albanD albanD albanD approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: nn release notes category topic: performance topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@janeyx99 @pytorchmergebot @albanD