Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[quant][fx][be] Remove _input_output_observed from backend_config #92589

Closed
wants to merge 9 commits into from
Closed

[quant][fx][be] Remove _input_output_observed from backend_config #92589

wants to merge 9 commits into from

Conversation

jerryzh168
Copy link
Contributor

@jerryzh168 jerryzh168 commented Jan 18, 2023 •
edited

Stack from ghstack (oldest at bottom):

Summary:
This is no longer needed, we can use dtype to decide whether an observer is needed or not

Test Plan:
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps

Reviewers:

Subscribers:

Tasks:

Tags:

@jerryzh168
[quant][fx][be] Remove _input_output_observed from backend_config
63849d8 
Summary:
This is no longer needed, we can use dtype to decide whether an observer is needed or not

Test Plan:
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@jerryzh168 jerryzh168 mentioned this pull request Jan 18, 2023
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 18, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92589

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c170fae:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@jerryzh168 jerryzh168 mentioned this pull request Jan 18, 2023
Closed
@github-actions github-actions bot added the release notes: quantization release notes category label Jan 18, 2023
jerryzh168 added a commit that referenced this pull request Jan 18, 2023
@jerryzh168
[quant][fx][be] Remove _input_output_observed from backend_config
aeb992f 
Summary:
This is no longer needed, we can use dtype to decide whether an observer is needed or not

Test Plan:
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 2a9ab99ee7a824954ff9af1a19655cc781d6c3b2
Pull Request resolved: #92589
@jerryzh168
Update on "[quant][fx][be] Remove _input_output_observed from backend…
da5d357 
…_config"

Summary:
This is no longer needed, we can use dtype to decide whether an observer is needed or not

Test Plan:
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request Jan 18, 2023
@jerryzh168
[quant][fx][be] Remove _input_output_observed from backend_config
df69d07 
Summary:
This is no longer needed, we can use dtype to decide whether an observer is needed or not

Test Plan:
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: de0818e7bff1ae077257f270563a83f5fb82b29a
Pull Request resolved: #92589
@jerryzh168
Update on "[quant][fx][be] Remove _input_output_observed from backend…
ed4f4b7 
…_config"

Summary:
This is no longer needed, we can use dtype to decide whether an observer is needed or not

Test Plan:
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request Jan 19, 2023
@jerryzh168
[quant][fx][be] Remove _input_output_observed from backend_config
2af2755 
Summary:
This is no longer needed, we can use dtype to decide whether an observer is needed or not

Test Plan:
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: a0ec0524eb9f06f3ee8b9967e416fdb7a5db857d
Pull Request resolved: #92589
jcaip
jcaip approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@jcaip jcaip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jerryzh168
Update on "[quant][fx][be] Remove _input_output_observed from backend…
54ea1f0 
…_config"

Summary:
This is no longer needed, we can use dtype to decide whether an observer is needed or not

Test Plan:
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@jerryzh168 jerryzh168 mentioned this pull request Jan 19, 2023
Closed
@jerryzh168
Update on "[quant][fx][be] Remove _input_output_observed from backend…
148d670 
…_config"

Summary:
This is no longer needed, we can use dtype to decide whether an observer is needed or not

Test Plan:
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@jerryzh168 jerryzh168 added the topic: not user facing topic category label Jan 20, 2023
@jerryzh168
Copy link
Contributor Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@jerryzh168
Update on "[quant][fx][be] Remove _input_output_observed from backend…
df4a08c 
…_config"

Summary:
This is no longer needed, we can use dtype to decide whether an observer is needed or not

Test Plan:
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/jerryzh168/846/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/92589)

pytorchmergebot pushed a commit that referenced this pull request Jan 23, 2023
@jerryzh168
[quant][fx][be] Remove _input_output_observed from backend_config
2438eef 
Summary:
This is no longer needed, we can use dtype to decide whether an observer is needed or not

Test Plan:
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 6a2f6bc89bed2beb502543e6365c189cf430df2a
Pull Request resolved: #92589
@jerryzh168
Update on "[quant][fx][be] Remove _input_output_observed from backend…
b79f5a2 
…_config"

Summary:
This is no longer needed, we can use dtype to decide whether an observer is needed or not

Test Plan:
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@jerryzh168
Update on "[quant][fx][be] Remove _input_output_observed from backend…
d4bf84b 
…_config"

Summary:
This is no longer needed, we can use dtype to decide whether an observer is needed or not

Test Plan:
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@jerryzh168
Update on "[quant][fx][be] Remove _input_output_observed from backend…
c170fae 
…_config"

Summary:
This is no longer needed, we can use dtype to decide whether an observer is needed or not

Test Plan:
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@jerryzh168
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 27, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/jerryzh168/846/head branch June 8, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcaip jcaip jcaip approved these changes

@andrewor14 andrewor14 Awaiting requested review from andrewor14

@vkuzo vkuzo Awaiting requested review from vkuzo

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: AO frontend release notes: quantization release notes category topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jerryzh168 @pytorchmergebot @jcaip