Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dtensor] disable gpu tests in op db first #92611

Closed
wants to merge 1 commit into from
Closed

[dtensor] disable gpu tests in op db first #92611

wants to merge 1 commit into from

Conversation

wanchaol
Copy link
Contributor

@wanchaol wanchaol commented Jan 19, 2023 •
edited

Stack from ghstack (oldest at bottom):

There seems to be some issue with the cuda tests where our CI aren't
capturing those failures (probably because of lacking 4 GPUs in CI
environment). Disabling it first and debug later

see #92343

@wanchaol
[dtensor] disable gpu tests in op db first
0ff4cc8 
There seems to be some issue with the cuda tests where our CI aren't
capturing those failures (probably because of lacking 4 GPUs in CI
environment). Disabling it first and debug later

see #92343

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 19, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92611

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 Failures

As of commit 0ff4cc8:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jan 19, 2023
wanchaol added a commit that referenced this pull request Jan 19, 2023
@wanchaol
[dtensor] disable gpu tests in op db first
c710745 
There seems to be some issue with the cuda tests where our CI aren't
capturing those failures (probably because of lacking 4 GPUs in CI
environment). Disabling it first and debug later

see #92343

ghstack-source-id: 5742a36c5c36a17a3de963e120b49e300cc762b3
Pull Request resolved: #92611
@wanchaol wanchaol added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 19, 2023
XilunWu
XilunWu approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@XilunWu XilunWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick stamp to solve CI issue.

@wanchaol
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-bionic-cuda11.6-py3.10-gcc7-sm86 / test (default, 3, 4, linux.g5.4xlarge.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

@wanchaol
Copy link
Contributor Author

@pytorchbot merge -f "failure not related"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@wanchaol wanchaol mentioned this pull request Jan 19, 2023
Closed
@facebook-github-bot facebook-github-bot deleted the gh/wanchaol/249/head branch June 8, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XilunWu XilunWu XilunWu approved these changes

@mrshenli mrshenli Awaiting requested review from mrshenli

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@H-Huang H-Huang Awaiting requested review from H-Huang

@awgu awgu Awaiting requested review from awgu

@kwen2501 kwen2501 Awaiting requested review from kwen2501

@fduwjj fduwjj Awaiting requested review from fduwjj

@wz337 wz337 Awaiting requested review from wz337

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wanchaol @pytorchmergebot @XilunWu