Add --timing flag, phase timing to @dynamo_timed

[voznesenskym]

Ex output:

 TIMING:
 entire_frame_compile:8.574629999999999
 backend_compile:5.26806

cc @mlazos @soumith @yanboliang @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @chunyuan-w @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @desertfire

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92637

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit cd1b009:

NEW FAILURES - The following jobs have failed:

• lintrunner

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[voznesenskym]

this is actually sus cause of nesting

[ezyang]

seems fine I guess

[voznesenskym]

@pytorchbot merge -f "local lintrunner -a doesn't show a diff. lintrunner init run, still no dice. I give up. yolo"

[pytorchmergebot]

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

[malfet]

@pytorchbot revert -f "Broke lint" -c ignoredsignal

[pytorch-bot]

❌ 🤖 pytorchbot command failed:

@pytorchbot revert: error: the following arguments are required: -m/--message

usage: @pytorchbot revert -m MESSAGE -c
                          {nosignal,ignoredsignal,landrace,weird,ghfirst}

Try @pytorchbot --help for more info.

[malfet]

@pytorchbot revert -m "Broke lint" -c ignoredsignal

[malfet]

@pytorchbot merge -f "local lintrunner -a doesn't show a diff. lintrunner init run, still no dice. I give up. yolo"

Not sure what was the point of doing this? If commit breaks CI it will be reverted, it's just the matter of time...

[albanD]

btw some lints (like flake8) cannot be automatically fixed. So it is expected that -a will not fix everything in some cases!

[voznesenskym]

btw some lints (like flake8) cannot be automatically fixed. So it is expected that -a will not fix everything in some cases!

I was plagued with two problems:

1. lintrunner -a does not look at everything (need lintrunner -m master)
2. Unrelated failures - In this case, the failures are on lines I did not touch. @malfet advised that it is a bad base. (current state)

[voznesenskym]

@pytorchmergebot rebase

[pytorchmergebot]

@pytorchbot successfully started a rebase job. Check the current status here

[pytorchmergebot]

Successfully rebased voz/timing onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout voz/timing && git pull --rebase)

[voznesenskym]

@pytorchbot merge -f "Linter failure for code I did not touch"

[pytorchmergebot]

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

[kit1980]

"Linter failure for code I did not touch"

Looks like the MyPy failure is because the the decorator dynamo_timed was removed from _convert_frame_assert, changing its type.

[kit1980]

@pytorchbot revert -m "Broke lint again" -c ignoredsignal

[pytorchmergebot]

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

[pytorchmergebot]

Reverting PR 92637 failed

Reason: Command git -C /home/runner/work/pytorch/pytorch revert --no-edit 5778c04a15ebf2bdf9a309a70d1018588ac68b63 returned non-zero exit code 1

Auto-merging benchmarks/dynamo/common.py
Auto-merging benchmarks/dynamo/parse_logs.py
CONFLICT (content): Merge conflict in benchmarks/dynamo/parse_logs.py
error: could not revert 5778c04a15... Add `--timing` flag, phase timing to @dynamo_timed (#92637)
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git revert --continue".
hint: You can instead skip this commit with "git revert --skip".
hint: To abort and get back to the state before "git revert",
hint: run "git revert --abort".

Details for Dev Infra team

Raised by workflow job

[voznesenskym]

Oof sorry about this, I've been banging into the linter like an idiot all week