Enable USE_CUDA
#92640
Closed
Enable USE_CUDA
#92640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92640
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 FailuresAs of commit fd715bc: NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base 438f12d:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D42616147 |
r-barnes
force-pushed
the
export-D42616147
branch
from
3404947
to
bc77bc4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D42616147 |
r-barnes
added a commit
to r-barnes/pytorch
that referenced
this pull request
Jan 20, 2023
Summary: Pull Request resolved: pytorch#92640 `USE_CUDA` is needed in the bazel definitions to ensure that `USE_CUDA` is applied everywhere it should be. Test Plan: Sandcastle Differential Revision: D42616147 fbshipit-source-id: 0d034f8bb2d3a9d30dc3ec41e10795eaa74073f0
|
This pull request was exported from Phabricator. Differential Revision: D42616147 |
r-barnes
force-pushed
the
export-D42616147
branch
from
bc77bc4
to
983ff1b
Compare
r-barnes
added a commit
to r-barnes/pytorch
that referenced
this pull request
Jan 23, 2023
Summary: Pull Request resolved: pytorch#92640 `USE_CUDA` is needed in the bazel definitions to ensure that `USE_CUDA` is applied everywhere it should be. Test Plan: Sandcastle Differential Revision: D42616147 fbshipit-source-id: 1662e0fba3f07ab2ea61df711b90c74cf44f2bfa
|
This pull request was exported from Phabricator. Differential Revision: D42616147 |
r-barnes
force-pushed
the
export-D42616147
branch
from
983ff1b
to
7f17549
Compare
r-barnes
added a commit
to r-barnes/pytorch
that referenced
this pull request
Jan 23, 2023
Summary: Pull Request resolved: pytorch#92640 `USE_CUDA` is needed in the bazel definitions to ensure that `USE_CUDA` is applied everywhere it should be. Test Plan: Sandcastle Differential Revision: D42616147 fbshipit-source-id: fe4274d51c6d80a92ae7de14813366a97ebdbff8
r-barnes
force-pushed
the
export-D42616147
branch
from
7f17549
to
e65a0ca
Compare
|
This pull request was exported from Phabricator. Differential Revision: D42616147 |
r-barnes
added a commit
to r-barnes/pytorch
that referenced
this pull request
Jan 25, 2023
Summary: Pull Request resolved: pytorch#92640 `USE_CUDA` is needed in the bazel definitions to ensure that `USE_CUDA` is applied everywhere it should be. Test Plan: Sandcastle Differential Revision: D42616147 fbshipit-source-id: 0baee98c3de9ce56bb2b05899a818659ffc8b076
|
This pull request was exported from Phabricator. Differential Revision: D42616147 |
r-barnes
force-pushed
the
export-D42616147
branch
from
e65a0ca
to
4d0f33d
Compare
r-barnes
added a commit
to r-barnes/pytorch
that referenced
this pull request
Jan 27, 2023
Summary: Pull Request resolved: pytorch#92640 `USE_CUDA` is needed in the bazel definitions to ensure that `USE_CUDA` is applied everywhere it should be. Test Plan: Sandcastle Differential Revision: D42616147 fbshipit-source-id: e0d3c36c3f521081a3b753940f1b700f60c4b949
|
This pull request was exported from Phabricator. Differential Revision: D42616147 |
r-barnes
force-pushed
the
export-D42616147
branch
from
4d0f33d
to
2b357d9
Compare
r-barnes
added a commit
to r-barnes/pytorch
that referenced
this pull request
Jan 30, 2023
Summary: Pull Request resolved: pytorch#92640 `USE_CUDA` is needed in the bazel definitions to ensure that `USE_CUDA` is applied everywhere it should be. Test Plan: Sandcastle Change ``` fbcode/caffe2/c10/cuda/test/build.bzl ``` to ``` dsa_tests = [ "impl/CUDAAssertionsTest_1_var_test.cu", "impl/CUDAAssertionsTest_catches_stream.cu", "impl/CUDAAssertionsTest_catches_thread_and_block_and_device.cu", "impl/CUDAAssertionsTest_from_2_processes.cu", "impl/CUDAAssertionsTest_multiple_writes_from_blocks_and_threads.cu", "impl/CUDAAssertionsTest_multiple_writes_from_multiple_blocks.cu", "impl/CUDAAssertionsTest_multiple_writes_from_same_block.cu", ] def define_targets(rules): rules.cc_test( name = "test", srcs = [ "impl/CUDATest.cpp", ], deps = [ "com_google_googletest//:gtest_main", "//c10/cuda", ], target_compatible_with = rules.requires_cuda_enabled(), ) rules.cc_test( name = "test_my_cuda_tests", # nocommit srcs = [ "impl/CUDAAssertionsTest_1_var_test.cu", ], deps = [ "com_google_googletest//:gtest_main", "//c10/cuda", ], target_compatible_with = rules.requires_cuda_enabled(), ) for src in dsa_tests: name = src.replace("impl/", "").replace(".cu", "") rules.cuda_library( name = "test_" + name + "_lib", srcs = [ src, ], deps = [ "com_google_googletest//:gtest_main", "//c10/cuda", ], target_compatible_with = rules.requires_cuda_enabled(), ) rules.cc_test( name = "test_" + name, deps = [ ":test_" + name + "_lib", ], ) ``` Differential Revision: D42616147 fbshipit-source-id: f64a9ad115677504541212f7b8a618c334c8ccd3
|
Rebase to get past failures: |
Summary: Pull Request resolved: pytorch#92640 `USE_CUDA` is needed in the bazel definitions to ensure that `USE_CUDA` is applied everywhere it should be. Test Plan: Sandcastle Change ``` fbcode/caffe2/c10/cuda/test/build.bzl ``` to ``` dsa_tests = [ "impl/CUDAAssertionsTest_1_var_test.cu", "impl/CUDAAssertionsTest_catches_stream.cu", "impl/CUDAAssertionsTest_catches_thread_and_block_and_device.cu", "impl/CUDAAssertionsTest_from_2_processes.cu", "impl/CUDAAssertionsTest_multiple_writes_from_blocks_and_threads.cu", "impl/CUDAAssertionsTest_multiple_writes_from_multiple_blocks.cu", "impl/CUDAAssertionsTest_multiple_writes_from_same_block.cu", ] def define_targets(rules): rules.cc_test( name = "test", srcs = [ "impl/CUDATest.cpp", ], deps = [ "com_google_googletest//:gtest_main", "//c10/cuda", ], target_compatible_with = rules.requires_cuda_enabled(), ) rules.cc_test( name = "test_my_cuda_tests", # nocommit srcs = [ "impl/CUDAAssertionsTest_1_var_test.cu", ], deps = [ "com_google_googletest//:gtest_main", "//c10/cuda", ], target_compatible_with = rules.requires_cuda_enabled(), ) for src in dsa_tests: name = src.replace("impl/", "").replace(".cu", "") rules.cuda_library( name = "test_" + name + "_lib", srcs = [ src, ], deps = [ "com_google_googletest//:gtest_main", "//c10/cuda", ], target_compatible_with = rules.requires_cuda_enabled(), ) rules.cc_test( name = "test_" + name, deps = [ ":test_" + name + "_lib", ], ) ``` Differential Revision: D42616147 fbshipit-source-id: c3cab120080a5b30a911bf25e2fdcff5f528668c
r-barnes
force-pushed
the
export-D42616147
branch
from
2b357d9
to
fd715bc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D42616147 |
ezyang
approved these changes
Feb 1, 2023
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
USE_CUDAis needed in the bazel definitions to ensure thatUSE_CUDAis applied everywhere it should be.We also fix some test code to use the correct properties.
Test Plan: Sandcastle
Differential Revision: D42616147