-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GroupNorm backward prop on CUDA #92671
Conversation
Fixes regression introduced by #89485 Adds test to prevent those regressions from happening in the future In process, discovered that GroupNormBackwards on CPU does not produce the same results if input and gradient memory_format is different
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92671
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 2436560: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…rd (#92668) Fixes the skipped part of the test on #92671. Align the input memory format and the grad memory format for GroupNorm backward. Pull Request resolved: #92668 Approved by: https://github.com/jgong5, https://github.com/malfet
Fixes regression introduced by #89485
Adds test to prevent those regressions from happening in the future In process, discovered that GroupNormBackwards on CPU does not produce the same results if input and gradient memory_format is different
Fixes #92166