import numpy before dlopen to prevent segfault #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soumith
requested changes
Mar 5, 2017
torch/__init__.py
Outdated
| @@ -31,6 +31,10 @@ | |||
| # automatically filled by the dynamic loader. | |||
| import os as _dl_flags | |||
|
|
|||
| # numpy *must* be imported before the call to setdlopenflags() or there is | |||
| # risk that later c modules will segfault when importing numpy | |||
| import numpy as np | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
jjsjann123
pushed a commit
to jjsjann123/pytorch
that referenced
this pull request
Aug 5, 2021
…h#928) Outdated due to - added invariance in computeAt csarofeen#838 - the change to barrier sync allowing block broadcast/reduce to be placed in conditional code - persistent buffers being considered on inputs
jjsjann123
pushed a commit
to jjsjann123/pytorch
that referenced
this pull request
Aug 5, 2021
Undoes some of the changes of pytorch#928 as layer norm half was failing. This just doesn't run computeWithOutputs on inputs that aren't inputs to the reduction.
zhuhong61
pushed a commit
to zhuhong61/pytorch
that referenced
this pull request
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see this tensorflow issue for the reason why this fixes #786