Swap file size on BE platform #92810
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92810
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit b1f42eb: NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
malfet
added
release notes: python_frontend
|
@pytorchbot merge -f "ASAN is failing on master, this change only affects power" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
AlekseiNikiforovIBM
pushed a commit
to AlekseiNikiforovIBM/pytorch
that referenced
this pull request
May 23, 2023
Fixes pytorch#92808 This PR fixes SIGSEGV on a big-endian machine when reading pickle data. The root cause is not to convert `size`, which is read from a file, from little-endian to big-endian while `size` is used in a method. The fix is to convert `size` on a big-endian machine instead of `nbytes`. I confirmed that the program in the issue works w/o SIGSEGV and the test passes, with this fix in master branch. ``` $ python test/test_autograd.py TestAutograd.test_pickle . ---------------------------------------------------------------------- Ran 1 test in 0.010s OK ``` Pull Request resolved: pytorch#92810 Approved by: https://github.com/malfet
AlekseiNikiforovIBM
pushed a commit
to AlekseiNikiforovIBM/pytorch
that referenced
this pull request
May 23, 2023
Fixes pytorch#92808 This PR fixes SIGSEGV on a big-endian machine when reading pickle data. The root cause is not to convert `size`, which is read from a file, from little-endian to big-endian while `size` is used in a method. The fix is to convert `size` on a big-endian machine instead of `nbytes`. I confirmed that the program in the issue works w/o SIGSEGV and the test passes, with this fix in master branch. ``` $ python test/test_autograd.py TestAutograd.test_pickle . ---------------------------------------------------------------------- Ran 1 test in 0.010s OK ``` Pull Request resolved: pytorch#92810 Approved by: https://github.com/malfet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #92808
This PR fixes SIGSEGV on a big-endian machine when reading pickle data.
The root cause is not to convert
size, which is read from a file, from little-endian to big-endian whilesizeis used in a method. The fix is to convertsizeon a big-endian machine instead ofnbytes.I confirmed that the program in the issue works w/o SIGSEGV and the test passes, with this fix in master branch.