-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PT-D][Checkpoint]rename init() #92829
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92829
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 8b1867b: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, should we do the same with storage layer?
Ye. Totally. Was having the same thoughts. Will do it in a separate PR then. |
@pytorchmergebot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Fix broken CI in pg_planner: ``` spmd/checkpoint/pg_planner.py:61:9: error: "init" undefined in superclass [misc] spmd/checkpoint/pg_planner.py:81:9: error: "init" undefined in superclass [misc] ``` This is changed due to pytorch/pytorch#92829.
Fixes #90346
Rename init() method in planner to be set_up_planner() to avoid confusion between init() and init().