Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MPI backend PG initialization #92847

Closed
wants to merge 3 commits into from

Conversation

H-Huang
Copy link
Member

@H-Huang H-Huang commented Jan 23, 2023

Stack from ghstack:

Fixes #92573

Add test to check that all default backends can be initialized to prevent the above from regressing in the future.

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 23, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92847

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8e83b40:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added release notes: distributed (c10d) release notes category labels Jan 23, 2023
H-Huang added a commit that referenced this pull request Jan 23, 2023
ghstack-source-id: ab30a1ab78aac605ca094e4317523aedfdedfc92
Pull Request resolved: #92847
Co-authored-by: Andrew Gu <31054793+awgu@users.noreply.github.com>
@H-Huang
Copy link
Member Author

H-Huang commented Jan 23, 2023

@pytorchbot merge

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 23, 2023

This PR needs to be approved by an authorized maintainer before merge.

@H-Huang
Copy link
Member Author

H-Huang commented Jan 24, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 24, 2023
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: PR 92847 is out of sync with the corresponding revision f9aab4b on branch origin/gh/H-Huang/105/orig that would be merged into master. This usually happens because there is a non ghstack change in the PR. Please sync them and try again (ex. make the changes on origin/gh/H-Huang/105/orig and run ghstack).

Details for Dev Infra team Raised by workflow job

Fixes #92573

Add test to check that all default backends can be initialized to prevent the above from regressing in the future.

[ghstack-poisoned]
H-Huang added a commit that referenced this pull request Jan 24, 2023
ghstack-source-id: 2479d241242a8b89b92674efe3bc39c745bc0c17
Pull Request resolved: #92847
@H-Huang
Copy link
Member Author

H-Huang commented Jan 24, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: distributed (c10d) release notes category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants