[PT-D][Checkpoint] Rename DCP storage layer init() #92869

wz337 · 2023-01-23T23:32:29Z

Rename DCP storage layer init() and update tests accordingly.

pytorch-bot · 2023-01-23T23:32:31Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92869

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit f0975e1:

NEW FAILURES - The following jobs have failed:

linux-bionic-py3.7-clang9 / test (dynamo, 1, 2, linux.2xlarge)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

kumpera

LGTM

pytorchmergebot · 2023-01-24T17:32:10Z

@pytorchbot successfully started a rebase job. Check the current status here

pytorchmergebot · 2023-01-24T17:32:13Z

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/viable/strict pull/92869/head returned non-zero exit code 1

Rebasing (1/2)
Auto-merging torch/distributed/checkpoint/filesystem.py
Auto-merging torch/distributed/checkpoint/state_dict_loader.py
CONFLICT (content): Merge conflict in torch/distributed/checkpoint/state_dict_loader.py
Auto-merging torch/distributed/checkpoint/state_dict_saver.py
CONFLICT (content): Merge conflict in torch/distributed/checkpoint/state_dict_saver.py
error: could not apply 0dc155b2c0... rename storage init()
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 0dc155b2c0... rename storage init()

Raised by https://github.com/pytorch/pytorch/actions/runs/3998826624

wz337 · 2023-01-24T17:56:05Z

@pytorchmergebot merge

pytorchmergebot · 2023-01-24T17:58:46Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2023-01-24T23:01:45Z

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / win-vs2019-cuda11.6-py3 / test (default, 1, 5, windows.g5.4xlarge.nvidia.gpu)

Details for Dev Infra team

Raised by workflow job

wz337 · 2023-01-25T00:07:02Z

@pytorchmergebot rebase

pytorchmergebot · 2023-01-25T00:09:01Z

@pytorchbot successfully started a rebase job. Check the current status here

pytorchmergebot · 2023-01-25T00:09:03Z

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/viable/strict pull/92869/head returned non-zero exit code 1

Rebasing (1/2)
Auto-merging torch/distributed/checkpoint/filesystem.py
Auto-merging torch/distributed/checkpoint/state_dict_loader.py
CONFLICT (content): Merge conflict in torch/distributed/checkpoint/state_dict_loader.py
Auto-merging torch/distributed/checkpoint/state_dict_saver.py
CONFLICT (content): Merge conflict in torch/distributed/checkpoint/state_dict_saver.py
error: could not apply 0dc155b2c0... rename storage init()
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 0dc155b2c0... rename storage init()

Raised by https://github.com/pytorch/pytorch/actions/runs/4001553632

wz337 · 2023-01-25T00:12:21Z

@pytorchmergebot rebase

pytorchmergebot · 2023-01-25T00:15:29Z

@pytorchbot successfully started a rebase job. Check the current status here

pytorchmergebot · 2023-01-25T00:15:32Z

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/viable/strict pull/92869/head returned non-zero exit code 1

Rebasing (1/2)
Auto-merging torch/distributed/checkpoint/filesystem.py
Auto-merging torch/distributed/checkpoint/state_dict_loader.py
CONFLICT (content): Merge conflict in torch/distributed/checkpoint/state_dict_loader.py
Auto-merging torch/distributed/checkpoint/state_dict_saver.py
CONFLICT (content): Merge conflict in torch/distributed/checkpoint/state_dict_saver.py
error: could not apply 0dc155b2c0... rename storage init()
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 0dc155b2c0... rename storage init()

Raised by https://github.com/pytorch/pytorch/actions/runs/4001584873

wz337 · 2023-01-25T06:08:36Z

@pytorchmergebot rebase

pytorchmergebot · 2023-01-25T06:10:27Z

@pytorchbot successfully started a rebase job. Check the current status here

pytorchmergebot · 2023-01-25T06:10:29Z

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/viable/strict pull/92869/head returned non-zero exit code 1

Rebasing (1/2)
Auto-merging torch/distributed/checkpoint/filesystem.py
Auto-merging torch/distributed/checkpoint/state_dict_loader.py
CONFLICT (content): Merge conflict in torch/distributed/checkpoint/state_dict_loader.py
Auto-merging torch/distributed/checkpoint/state_dict_saver.py
CONFLICT (content): Merge conflict in torch/distributed/checkpoint/state_dict_saver.py
error: could not apply 0dc155b2c0... rename storage init()
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 0dc155b2c0... rename storage init()

Raised by https://github.com/pytorch/pytorch/actions/runs/4003351680

wz337 · 2023-01-25T17:04:38Z

@pytorchmergebot rebase

pytorchmergebot · 2023-01-25T17:06:29Z

@pytorchbot successfully started a rebase job. Check the current status here

pytorchmergebot · 2023-01-25T17:06:31Z

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/viable/strict pull/92869/head returned non-zero exit code 1

Rebasing (1/2)
Auto-merging torch/distributed/checkpoint/filesystem.py
Auto-merging torch/distributed/checkpoint/state_dict_loader.py
CONFLICT (content): Merge conflict in torch/distributed/checkpoint/state_dict_loader.py
Auto-merging torch/distributed/checkpoint/state_dict_saver.py
CONFLICT (content): Merge conflict in torch/distributed/checkpoint/state_dict_saver.py
error: could not apply 0dc155b2c0... rename storage init()
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 0dc155b2c0... rename storage init()

Raised by https://github.com/pytorch/pytorch/actions/runs/4008219597

wz337 · 2023-01-25T17:40:09Z

@pytorchmergebot merge

pytorchmergebot · 2023-01-25T17:41:52Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2023-01-25T17:46:59Z

Merge failed

Reason: 1 mandatory check(s) failed (Rule Distributed). The first few are:

pull / linux-bionic-py3.7-clang9 / test (dynamo, 1, 2, linux.2xlarge)

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

wz337 · 2023-01-25T18:00:43Z

@pytorchmergebot rebase

pytorchmergebot · 2023-01-25T18:02:53Z

@pytorchbot successfully started a rebase job. Check the current status here

pytorchmergebot · 2023-01-25T18:02:57Z

Tried to rebase and push PR #92869, but it was already up to date

wz337 · 2023-01-25T23:51:07Z

@pytorchmergebot merge -f "unrelated test failures https://github.com/pytorch/pytorch/actions/runs/4008358242/jobs/6882601831"

pytorchmergebot · 2023-01-25T23:52:42Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

wz337 marked this pull request as ready for review January 23, 2023 23:33

wz337 requested review from mrshenli, zhaojuanmao, rohan-varma, H-Huang, awgu, kwen2501 and wanchaol as code owners January 23, 2023 23:33

wz337 requested review from kumpera and removed request for kumpera January 23, 2023 23:35

kumpera approved these changes Jan 24, 2023

View reviewed changes

wz337 requested review from ezyang, Chillee, robieta, mruberry, ngimel, lezcano, nikitaved, IvanYashchuk, a team, BowenBao, abock, jerryzh168, salilsdesai, kimishpatel, digantdesai, jianyuh and albanD as code owners January 24, 2023 17:21

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 24, 2023

rename storage init()

f0975e1

pytorchmergebot added the Merged label Jan 25, 2023

pytorchmergebot closed this in dd05f02 Jan 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PT-D][Checkpoint] Rename DCP storage layer init() #92869

[PT-D][Checkpoint] Rename DCP storage layer init() #92869

wz337 commented Jan 23, 2023 •

edited

pytorch-bot bot commented Jan 23, 2023 •

edited

kumpera left a comment

pytorchmergebot commented Jan 24, 2023

pytorchmergebot commented Jan 24, 2023

wz337 commented Jan 24, 2023

pytorchmergebot commented Jan 24, 2023

pytorchmergebot commented Jan 24, 2023

wz337 commented Jan 25, 2023

pytorchmergebot commented Jan 25, 2023

pytorchmergebot commented Jan 25, 2023

wz337 commented Jan 25, 2023

pytorchmergebot commented Jan 25, 2023

pytorchmergebot commented Jan 25, 2023

wz337 commented Jan 25, 2023

pytorchmergebot commented Jan 25, 2023

pytorchmergebot commented Jan 25, 2023

wz337 commented Jan 25, 2023

pytorchmergebot commented Jan 25, 2023

pytorchmergebot commented Jan 25, 2023

wz337 commented Jan 25, 2023

pytorchmergebot commented Jan 25, 2023

pytorchmergebot commented Jan 25, 2023

wz337 commented Jan 25, 2023

pytorchmergebot commented Jan 25, 2023

pytorchmergebot commented Jan 25, 2023

wz337 commented Jan 25, 2023

pytorchmergebot commented Jan 25, 2023

[PT-D][Checkpoint] Rename DCP storage layer init() #92869

[PT-D][Checkpoint] Rename DCP storage layer init() #92869

Conversation

wz337 commented Jan 23, 2023 • edited

pytorch-bot bot commented Jan 23, 2023 • edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92869

❌ 1 Failures

kumpera left a comment

Choose a reason for hiding this comment

pytorchmergebot commented Jan 24, 2023

pytorchmergebot commented Jan 24, 2023

wz337 commented Jan 24, 2023

pytorchmergebot commented Jan 24, 2023

Merge started

pytorchmergebot commented Jan 24, 2023

Merge failed

wz337 commented Jan 25, 2023

pytorchmergebot commented Jan 25, 2023

pytorchmergebot commented Jan 25, 2023

wz337 commented Jan 25, 2023

pytorchmergebot commented Jan 25, 2023

pytorchmergebot commented Jan 25, 2023

wz337 commented Jan 25, 2023

pytorchmergebot commented Jan 25, 2023

pytorchmergebot commented Jan 25, 2023

wz337 commented Jan 25, 2023

pytorchmergebot commented Jan 25, 2023

pytorchmergebot commented Jan 25, 2023

wz337 commented Jan 25, 2023

pytorchmergebot commented Jan 25, 2023

Merge started

pytorchmergebot commented Jan 25, 2023

Merge failed

wz337 commented Jan 25, 2023

pytorchmergebot commented Jan 25, 2023

pytorchmergebot commented Jan 25, 2023

wz337 commented Jan 25, 2023

pytorchmergebot commented Jan 25, 2023

Merge started

wz337 commented Jan 23, 2023 •

edited

pytorch-bot bot commented Jan 23, 2023 •

edited