-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exponential_ few fixes (1) lambda > 0 (2) mkl kernel to continuous (3) better error log on dtype #92891
exponential_ few fixes (1) lambda > 0 (2) mkl kernel to continuous (3) better error log on dtype #92891
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92891
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 5 PendingAs of commit a30aa39: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add a TORCH_CHECK
throwing a more informative error?
Thanks @lezcano, should we add such check for other exponential distribution implementations as well? Currently, the error is |
Yeah, that'd be great! If this was implemented properly, all the checks would be shared by all the implementations and then we would dispatch to the actual backend, but I guess this is not the case. |
@pytorchbot rebase -b master |
@pytorchbot successfully started a rebase job. Check the current status here |
Successfully rebased |
81ad5e9
to
49e9c95
Compare
…om/min-jean-cho/pytorch into minjean/mkl_exponential_continuous
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Exponential distribution is continuous. Fixes CPU MKL exponential implementation to exclude integer dtypes.
Additional Context
Related to #92709. This issue propagates to OpInfo of exponential.
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10