[Vulkan][Optimize for Mobile] Avoid dereferencing element [0] if the vector is empty #92918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92918
Note: Links to docs will display an error until the docs builds have been completed. ❌ 6 FailuresAs of commit 608ec0b: NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base 438f12d:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D41296037 |
SS-JIA
approved these changes
Jan 24, 2023
kirklandsign
approved these changes
Jan 24, 2023
|
This pull request was exported from Phabricator. Differential Revision: D41296037 |
salilsdesai
force-pushed
the
export-D41296037
branch
from
582e12e
to
0490550
Compare
salilsdesai
added a commit
to salilsdesai/pytorch
that referenced
this pull request
Jan 25, 2023
…vector is empty (pytorch#92918) Summary: Pull Request resolved: pytorch#92918 Avoid dereferencing element [0] if the vector is empty. ___ In ```transferInputOutputBackends```, one of the rewrite passes for Vulkan ```optimize_for_mobile```, an out of bounds access happens when trying to insert a backend transfer for an input if that input's ```uses()``` is empty. This diff corrects that issue. Test Plan: Run tests ___ Phabricator + CI Tests Reviewed By: SS-JIA Differential Revision: D41296037 fbshipit-source-id: 5e8219faf020104435734c1fb25af612d8408f5a
salilsdesai
force-pushed
the
export-D41296037
branch
from
0490550
to
cd09cb3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41296037 |
salilsdesai
added a commit
to salilsdesai/pytorch
that referenced
this pull request
Jan 27, 2023
…vector is empty (pytorch#92918) Summary: Pull Request resolved: pytorch#92918 Avoid dereferencing element [0] if the vector is empty. ___ In ```transferInputOutputBackends```, one of the rewrite passes for Vulkan ```optimize_for_mobile```, an out of bounds access happens when trying to insert a backend transfer for an input if that input's ```uses()``` is empty. This diff corrects that issue. Test Plan: Run tests ___ Phabricator + CI Tests Reviewed By: SS-JIA Differential Revision: D41296037 fbshipit-source-id: 54b60872b1a8e4a02ddb60fa034ed75db2bf86f1
|
This pull request was exported from Phabricator. Differential Revision: D41296037 |
salilsdesai
force-pushed
the
export-D41296037
branch
from
cd09cb3
to
bb0a9d3
Compare
salilsdesai
added a commit
to salilsdesai/pytorch
that referenced
this pull request
Jan 28, 2023
…vector is empty (pytorch#92918) Summary: Pull Request resolved: pytorch#92918 Avoid dereferencing element [0] if the vector is empty. ___ In ```transferInputOutputBackends```, one of the rewrite passes for Vulkan ```optimize_for_mobile```, an out of bounds access happens when trying to insert a backend transfer for an input if that input's ```uses()``` is empty. This diff corrects that issue. Test Plan: Run tests ___ Phabricator + CI Tests Reviewed By: SS-JIA Differential Revision: D41296037 fbshipit-source-id: 8abe599d7e26ed76622621ff64e4a4b50b8cf1bd
|
This pull request was exported from Phabricator. Differential Revision: D41296037 |
salilsdesai
force-pushed
the
export-D41296037
branch
from
bb0a9d3
to
0c9023a
Compare
salilsdesai
added a commit
to salilsdesai/pytorch
that referenced
this pull request
Jan 30, 2023
…vector is empty (pytorch#92918) Summary: Pull Request resolved: pytorch#92918 Avoid dereferencing element [0] if the vector is empty. ___ In ```transferInputOutputBackends```, one of the rewrite passes for Vulkan ```optimize_for_mobile```, an out of bounds access happens when trying to insert a backend transfer for an input if that input's ```uses()``` is empty. This diff corrects that issue. Test Plan: Run tests ___ Phabricator + CI Tests Reviewed By: SS-JIA, dmm-fb Differential Revision: D41296037 fbshipit-source-id: ec82cb7ea48425a59e44f3132e2e3f6baa442a24
…vector is empty (pytorch#92918) Summary: Pull Request resolved: pytorch#92918 Avoid dereferencing element [0] if the vector is empty. ___ In ```transferInputOutputBackends```, one of the rewrite passes for Vulkan ```optimize_for_mobile```, an out of bounds access happens when trying to insert a backend transfer for an input if that input's ```uses()``` is empty. This diff corrects that issue. Test Plan: Run tests ___ Phabricator + CI Tests Reviewed By: SS-JIA, dmm-fb Differential Revision: D41296037 fbshipit-source-id: b0b385bff829f1b74b6aa4a4c72c0220fc9450bf
salilsdesai
force-pushed
the
export-D41296037
branch
from
0c9023a
to
608ec0b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41296037 |
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Avoid dereferencing element [0] if the vector is empty.
In
transferInputOutputBackends, one of the rewrite passes for Vulkanoptimize_for_mobile, an out of bounds access happens when trying to insert a backend transfer for an input if that input'suses()is empty. This diff corrects that issue.Test Plan:
Run tests
Phabricator + CI Tests
Reviewed By: SS-JIA
Differential Revision: D41296037