[FSDP][optim_state_dict] Ensure correct devices for tensors when doing all_gather #92992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g all_gather [ghstack-poisoned]
fegin
requested review from
mrshenli,
zhaojuanmao,
rohan-varma,
H-Huang,
awgu,
kwen2501 and
wanchaol
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92992
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 90022ac: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
release notes: distributed (fsdp)
fegin
added a commit
that referenced
this pull request
Jan 25, 2023
…g all_gather ghstack-source-id: 3bb40dbbac0df7a2772e96ee5c1005ce227bf12b Pull Request resolved: #92992
…s when doing all_gather" When doing `_all_gather_optim_state`, we need to ensure that `step` tensors are on CPU and other tensors are on GPUs. This PR add the logic to ensure the locality. [ghstack-poisoned]
fegin
added a commit
that referenced
this pull request
Jan 25, 2023
…g all_gather ghstack-source-id: f9f72d8fbbce3a7a90b2c971cca760c0b47bf26c Pull Request resolved: #92992
…s when doing all_gather" When doing `_all_gather_optim_state`, we need to ensure that `step` tensors are on CPU and other tensors are on GPUs. This PR add the logic to ensure the locality. [ghstack-poisoned]
fegin
added a commit
that referenced
this pull request
Jan 26, 2023
…g all_gather ghstack-source-id: b6c2b50393ff9935614b84df33c388847458463a Pull Request resolved: #92992
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
When doing
_all_gather_optim_state, we need to ensure thatsteptensors are on CPU and other tensors are on GPUs. This PR add the logic to ensure the locality.