Make CPU inductor work with dynamic shapes #93077
Conversation
These errors were found by looking at wav2vec2 See #91719 Signed-off-by: Edward Z. Yang <ezyang@meta.com> [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/93077
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f2ad5c4: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
github-actions
bot
requested review from
albanD,
antoniojkim,
bdhirsh,
Chillee,
jbschlosser,
miladm,
SherlockNoMad,
voznesenskym and
wconstab
ezyang
added
topic: bug fixes
| if not dynamo_config.dynamic_shapes: | ||
| gm = mkldnn_fuse_fx(gm, example_inputs) |
There was a problem hiding this comment.
What's the problem of running mkldnn_fuse_fx with dynamic shapes? Fusions should work with both static and dynamic shapes. We can follow up with the fix to enable the dynamic shape. cc @XiaobingSuper
There was a problem hiding this comment.
The problem is that some of the mkl ops we fuse into don't have meta formulas, like the packing stuff. Whenever you work out the formulas here we can reenable this! However when I looked at it briefly it was not obvious how to fix
There was a problem hiding this comment.
Thanks for the info, will do a follow-up fix to enable dynamic shapes here.
These errors were found by looking at wav2vec2 See #91719 Signed-off-by: Edward Z. Yang <ezyangmeta.com> cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: trunk / macos-12-py3-x86-64 / build Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Stack from ghstack (oldest at bottom):
These errors were found by looking at wav2vec2
See #91719
Signed-off-by: Edward Z. Yang ezyang@meta.com
cc @mlazos @soumith @voznesenskym @yanboliang @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @chunyuan-w @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @desertfire