Make segment_reduce properly private. #93166
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/93166
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 FailuresAs of commit c759027: NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base 438f12d:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
albanD
force-pushed
the
hide_segment_reduce
branch
2 times, most recently
from
3a6fdd8
to
66b1b2e
Compare
albanD
force-pushed
the
hide_segment_reduce
branch
from
9924590
to
59744d8
Compare
albanD
requested review from
ezyang,
Chillee,
zou3519,
mruberry,
ngimel,
mrshenli,
zhaojuanmao,
rohan-varma,
H-Huang,
awgu,
kwen2501 and
wanchaol
as code owners
|
fix pr title plz |
|
I can't reproduce the lint error locally. Also all other use of |
|
@albanD has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@albanD has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@albanD has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@pytorchbot merge -f 'Landed internally' (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
I am attempting not to change the aten function to reduce the amount of BC issues on the torchscript side.
cc @ezyang @gchanan @mlazos @soumith @voznesenskym @yanboliang @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @desertfire @chunyuan-w