Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dtensor] add split_with_sizes op #93957

Closed
wants to merge 2 commits into from

Conversation

wanchaol
Copy link
Contributor

@wanchaol wanchaol commented Feb 2, 2023

Stack from ghstack (oldest at bottom):

add the split_with_sizes op, sharing with split op impl

add the split_with_sizes op, sharing with split op impl

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 2, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/93957

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit cc65ace:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

wanchaol added a commit that referenced this pull request Feb 2, 2023
add the split_with_sizes op, sharing with split op impl

ghstack-source-id: fcc70d10122df2e81b6be1bb1dddb95d7dd46d07
Pull Request resolved: #93957
@wanchaol wanchaol added the release notes: distributed (dtensor) release notes category label Feb 2, 2023
Copy link
Contributor

@XilunWu XilunWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thx for putting the common logic into a function!

add the split_with_sizes op, sharing with split op impl

[ghstack-poisoned]
wanchaol added a commit that referenced this pull request Feb 2, 2023
add the split_with_sizes op, sharing with split op impl

ghstack-source-id: 6ca7197b8c743505c7b979657ca92f5b3a11cca9
Pull Request resolved: #93957
@wanchaol
Copy link
Contributor Author

wanchaol commented Feb 3, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 3, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/wanchaol/254/head branch June 8, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: distributed (dtensor) release notes category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants