fix numpy1.24 deprecations in unittests #93997
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppwwyyxx
requested review from
mruberry,
ngimel and
jerryzh168
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/93997
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 777cc5a: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ngimel
approved these changes
Feb 2, 2023
jerryzh168
approved these changes
Feb 2, 2023
|
Could this pull request be merged please? Would be nice not to have to suppress warnings and to be able to update numpy to versions above 1.23.5. Thanks! |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: This PR is too stale; the last push date was more than 3 days ago. Please rebase and try again. You can rebase by leaving the following comment on this PR: Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
ppwwyyxx
added a commit
to ppwwyyxx/pytorch
that referenced
this pull request
Feb 20, 2023
Fixes pytorch#91329 Pull Request resolved: pytorch#93997 Approved by: https://github.com/ngimel, https://github.com/jerryzh168
This was referenced Feb 20, 2023
atalman
pushed a commit
that referenced
this pull request
Feb 22, 2023
Fixes #91329 Pull Request resolved: #93997 Approved by: https://github.com/ngimel, https://github.com/jerryzh168
pruthvistony
added a commit
to ROCm/pytorch
that referenced
this pull request
May 2, 2023
This reverts commit 9bb2fe3.
pruthvistony
pushed a commit
to ROCm/pytorch
that referenced
this pull request
May 3, 2023
Fixes pytorch#91329 Pull Request resolved: pytorch#93997 Approved by: https://github.com/ngimel, https://github.com/jerryzh168
pruthvistony
pushed a commit
to ROCm/pytorch
that referenced
this pull request
May 24, 2023
Fixes pytorch#91329 Pull Request resolved: pytorch#93997 Approved by: https://github.com/ngimel, https://github.com/jerryzh168
pruthvistony
pushed a commit
to ROCm/pytorch
that referenced
this pull request
May 24, 2023
Fixes pytorch#91329 Pull Request resolved: pytorch#93997 Approved by: https://github.com/ngimel, https://github.com/jerryzh168
pruthvistony
pushed a commit
to ROCm/pytorch
that referenced
this pull request
May 24, 2023
Fixes pytorch#91329 Pull Request resolved: pytorch#93997 Approved by: https://github.com/ngimel, https://github.com/jerryzh168
jeffdaily
added a commit
to ROCm/pytorch
that referenced
this pull request
Jun 9, 2023
cherry-pick of pytorch#93997 introduced a bug. torch/utils/tensorboard/summary.py int32 --> np.int32
jeffdaily
added a commit
to ROCm/pytorch
that referenced
this pull request
Jun 9, 2023
cherry-pick of pytorch#93997 introduced a bug. torch/utils/tensorboard/summary.py int32 --> np.int32
jeffdaily
added a commit
to ROCm/pytorch
that referenced
this pull request
Jun 9, 2023
cherry-pick of pytorch#93997 introduced a bug. torch/utils/tensorboard/summary.py int32 --> np.int32
jataylo
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Jul 12, 2023
Fixes pytorch#91329 Pull Request resolved: pytorch#93997 Approved by: https://github.com/ngimel, https://github.com/jerryzh168
jataylo
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Jul 12, 2023
cherry-pick of pytorch#93997 introduced a bug. torch/utils/tensorboard/summary.py int32 --> np.int32
jhavukainen
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Mar 15, 2024
Fixes pytorch#91329 Pull Request resolved: pytorch#93997 Approved by: https://github.com/ngimel, https://github.com/jerryzh168
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #91329