Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix functionalization resize stride compute #94018

Closed
wants to merge 16 commits into from

Conversation

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 3, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/94018

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8b4e38b:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I don't understand. The old code looks right and the new code looks like you do an out of bounds strides access on the first iteration

uncovered from an OpInfo in inductor, when I turned on functionalization




[ghstack-poisoned]
@bdhirsh
Copy link
Contributor Author

bdhirsh commented Feb 3, 2023

yep you're right - somehow I convinced myself that my test passed locally. Updated, to use a convenient existing util that we have (the bug was that I should have been doing strides[i] = strides[i+1] * sizes[i+1] instead of strides[i] = strides[i+1] * sizes[i]).

@albanD albanD removed their request for review February 3, 2023 16:07
uncovered from an OpInfo in inductor, when I turned on functionalization




[ghstack-poisoned]
uncovered from an OpInfo in inductor, when I turned on functionalization




[ghstack-poisoned]
uncovered from an OpInfo in inductor, when I turned on functionalization




[ghstack-poisoned]
uncovered from an OpInfo in inductor, when I turned on functionalization




[ghstack-poisoned]
@bdhirsh bdhirsh added release notes: composability release notes category topic: bug fixes topic category labels Feb 7, 2023
uncovered from an OpInfo in inductor, when I turned on functionalization




[ghstack-poisoned]
uncovered from an OpInfo in inductor, when I turned on functionalization




[ghstack-poisoned]
uncovered from an OpInfo in inductor, when I turned on functionalization




[ghstack-poisoned]
uncovered from an OpInfo in inductor, when I turned on functionalization




[ghstack-poisoned]
uncovered from an OpInfo in inductor, when I turned on functionalization




[ghstack-poisoned]
uncovered from an OpInfo in inductor, when I turned on functionalization




[ghstack-poisoned]
uncovered from an OpInfo in inductor, when I turned on functionalization




[ghstack-poisoned]
uncovered from an OpInfo in inductor, when I turned on functionalization




[ghstack-poisoned]
blzheng pushed a commit to blzheng/pytorch that referenced this pull request Feb 10, 2023
ghstack-source-id: 2c969f8458282b98041fee409d1252e6ec26d0e1
Pull Request resolved: pytorch#94018
uncovered from an OpInfo in inductor, when I turned on functionalization




[ghstack-poisoned]
uncovered from an OpInfo in inductor, when I turned on functionalization




[ghstack-poisoned]
@facebook-github-bot facebook-github-bot deleted the gh/bdhirsh/374/head branch June 8, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants