-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix functionalization resize stride compute #94018
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/94018
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8b4e38b: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I don't understand. The old code looks right and the new code looks like you do an out of bounds strides access on the first iteration
uncovered from an OpInfo in inductor, when I turned on functionalization [ghstack-poisoned]
yep you're right - somehow I convinced myself that my test passed locally. Updated, to use a convenient existing util that we have (the bug was that I should have been doing |
uncovered from an OpInfo in inductor, when I turned on functionalization [ghstack-poisoned]
uncovered from an OpInfo in inductor, when I turned on functionalization [ghstack-poisoned]
uncovered from an OpInfo in inductor, when I turned on functionalization [ghstack-poisoned]
uncovered from an OpInfo in inductor, when I turned on functionalization [ghstack-poisoned]
uncovered from an OpInfo in inductor, when I turned on functionalization [ghstack-poisoned]
uncovered from an OpInfo in inductor, when I turned on functionalization [ghstack-poisoned]
uncovered from an OpInfo in inductor, when I turned on functionalization [ghstack-poisoned]
uncovered from an OpInfo in inductor, when I turned on functionalization [ghstack-poisoned]
uncovered from an OpInfo in inductor, when I turned on functionalization [ghstack-poisoned]
uncovered from an OpInfo in inductor, when I turned on functionalization [ghstack-poisoned]
uncovered from an OpInfo in inductor, when I turned on functionalization [ghstack-poisoned]
uncovered from an OpInfo in inductor, when I turned on functionalization [ghstack-poisoned]
ghstack-source-id: 2c969f8458282b98041fee409d1252e6ec26d0e1 Pull Request resolved: pytorch#94018
uncovered from an OpInfo in inductor, when I turned on functionalization [ghstack-poisoned]
uncovered from an OpInfo in inductor, when I turned on functionalization [ghstack-poisoned]
uncovered from an OpInfo in inductor, when I turned on functionalization
Stack from ghstack (oldest at bottom):