sparse compressed tensor validation without syncs for low-(batch)dim tensors. #94048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikitaved
added
module: sparse
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/94048
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 15c0078: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
nikitaved
force-pushed
the
nikitaved/compressed_tensor_validation_remove_sync
branch
from
232de1f
to
ebdac2d
Compare
nikitaved
force-pushed
the
nikitaved/compressed_tensor_validation_remove_sync
branch
from
ebdac2d
to
e70e57e
Compare
nikitaved
changed the title
nikitaved
force-pushed
the
nikitaved/compressed_tensor_validation_remove_sync
branch
from
e70e57e
to
828ab25
Compare
|
LGTM. |
alexsamardzic
approved these changes
Feb 6, 2023
|
@pytorchbot rebase |
|
@pytorchbot successfully started a rebase job. Check the current status here |
|
Successfully rebased |
pytorchmergebot
force-pushed
the
nikitaved/compressed_tensor_validation_remove_sync
branch
from
ab7363f
to
bd78cc2
Compare
pytorchmergebot
requested review from
mrshenli,
zhaojuanmao,
rohan-varma,
H-Huang,
awgu,
kwen2501 and
wanchaol
as code owners
pytorchmergebot
referenced
this pull request
Mar 3, 2023
This PR improves COO intersection primitives by: * making it sync-less (dims <= 8, can be changed to any value that fits stack). * improving performance with much less kernel calls. Pull Request resolved: #92976 Approved by: https://github.com/cpuhrsch, https://github.com/pearu
pytorchmergebot
added a commit
that referenced
this pull request
Mar 3, 2023
This reverts commit b033594. Reverted #92976 on behalf of https://github.com/seemethere due to Need to revert this so I can revert #94048 cleanly
|
@pytorchbot revert -c ghfirst -m "Sign compare between size_t and int64_t is not allowed" |
|
@pytorchbot successfully started a revert job. Check the current status here. |
|
@nikitaved your PR has been successfully reverted. |
pytorchmergebot
added a commit
that referenced
this pull request
Mar 3, 2023
…tch)dim tensors. (#94048)" This reverts commit 7901f2d. Reverted #94048 on behalf of https://github.com/seemethere due to Sign compare between size_t and int64_t is not allowed
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 5, 2023
…tensors. (#94048) As per title. Sync is still unavoidable for super high-dim tensors. Pull Request resolved: pytorch/pytorch#94048 Approved by: https://github.com/alexsamardzic, https://github.com/cpuhrsch
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 5, 2023
This reverts commit b033594. Reverted pytorch/pytorch#92976 on behalf of https://github.com/seemethere due to Need to revert this so I can revert pytorch/pytorch#94048 cleanly
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 5, 2023
…tch)dim tensors. (#94048)" This reverts commit 7901f2d. Reverted pytorch/pytorch#94048 on behalf of https://github.com/seemethere due to Sign compare between size_t and int64_t is not allowed
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 5, 2023
…tensors. (#94048) As per title. Sync is still unavoidable for super high-dim tensors. Pull Request resolved: pytorch/pytorch#94048 Approved by: https://github.com/alexsamardzic, https://github.com/cpuhrsch
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 5, 2023
This reverts commit b033594. Reverted pytorch/pytorch#92976 on behalf of https://github.com/seemethere due to Need to revert this so I can revert pytorch/pytorch#94048 cleanly
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 5, 2023
…tch)dim tensors. (#94048)" This reverts commit 7901f2d. Reverted pytorch/pytorch#94048 on behalf of https://github.com/seemethere due to Sign compare between size_t and int64_t is not allowed
…taved/compressed_tensor_validation_remove_sync
|
@pytorchbot merge -g |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
ydwu4
pushed a commit
to ydwu4/pytorch
that referenced
this pull request
Mar 10, 2023
…#92976)" This reverts commit b033594. Reverted pytorch#92976 on behalf of https://github.com/seemethere due to Need to revert this so I can revert pytorch#94048 cleanly
ydwu4
pushed a commit
to ydwu4/pytorch
that referenced
this pull request
Mar 10, 2023
…tch)dim tensors. (pytorch#94048)" This reverts commit 7901f2d. Reverted pytorch#94048 on behalf of https://github.com/seemethere due to Sign compare between size_t and int64_t is not allowed
ydwu4
pushed a commit
to ydwu4/pytorch
that referenced
this pull request
Mar 10, 2023
…tensors. (pytorch#94048) As per title. Sync is still unavoidable for super high-dim tensors. Pull Request resolved: pytorch#94048 Approved by: https://github.com/alexsamardzic, https://github.com/cpuhrsch
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 12, 2023
…tensors. (#94048) As per title. Sync is still unavoidable for super high-dim tensors. Pull Request resolved: pytorch/pytorch#94048 Approved by: https://github.com/alexsamardzic, https://github.com/cpuhrsch
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 12, 2023
…tensors. (#94048) As per title. Sync is still unavoidable for super high-dim tensors. Pull Request resolved: pytorch/pytorch#94048 Approved by: https://github.com/alexsamardzic, https://github.com/cpuhrsch
ydwu4
added a commit
to ydwu4/pytorch
that referenced
this pull request
Mar 13, 2023
…#92976)" This reverts commit b033594. Reverted pytorch#92976 on behalf of https://github.com/seemethere due to Need to revert this so I can revert pytorch#94048 cleanly
ydwu4
added a commit
to ydwu4/pytorch
that referenced
this pull request
Mar 13, 2023
…tch)dim tensors. (pytorch#94048)" This reverts commit 7901f2d. Reverted pytorch#94048 on behalf of https://github.com/seemethere due to Sign compare between size_t and int64_t is not allowed
ydwu4
added a commit
to ydwu4/pytorch
that referenced
this pull request
Mar 13, 2023
…tensors. (pytorch#94048) As per title. Sync is still unavoidable for super high-dim tensors. Pull Request resolved: pytorch#94048 Approved by: https://github.com/alexsamardzic, https://github.com/cpuhrsch
pruthvistony
added a commit
to ROCm/pytorch
that referenced
this pull request
May 2, 2023
…tch)dim tensors. (pytorch#94048)" This reverts commit 7901f2d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title. Sync is still unavoidable for super high-dim tensors.
cc @alexsamardzic @pearu @cpuhrsch @amjames @bhosmer