update xnnpack to newer version and update API usage in pytorch #94330

tiandiao123 · 2023-02-07T20:09:37Z

Summary:
Update XNNPACK to 51a987591a6fc9f0fc0707077f53d763ac132cbf (https://github.com/google/XNNPACK/commits/51a987591a6fc9f0fc0707077f53d763ac132cbf)

Update the corresponding CMake and BUCK rules, as well as the generate_wrapper.py for the new version.

Due to XNNPACK having already changed a lot. We need to update XNNPACK in this time for many reasons. Firstly, XNNAPCK has updated a lot, and developers' community has re-factored codes' such as API changes. We can see from their cmakefile.txt to see there are many changes! Thus, in order to follow up upstream. We need to update xnnpack at this time. It is very crucial for our future development. Also, many projects are relying on newer versions of XNNPACK, so we probably need to update XNNPACK third-party libs at this time. we have some api changes of XNNPACK, so we also need to update them in this time. We also update target building files and generate-wrapper.py file to make this process more automatically. The original target files have some files which are missing, so we add them into buck2 building files so that it can build and test XNNPACK successfully.

Test Plan:
buck2 build //xplat/third-party/XNNPACK:operators
buck2 build //xplat/third-party/XNNPACK:XNNPACK
buck2 test fbcode//caffe2/test:xnnpack_integration

Reviewed By: digantdesai

Differential Revision: D43092938

cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @albanD

linux-foundation-easycla · 2023-02-07T20:09:41Z

The committers listed above are authorized under a signed CLA.

✅ login: tiandiao123 / name: Cuiqing Li (6b67439)

pytorch-bot · 2023-02-07T20:09:41Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/94330

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c441e53:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2023-02-07T20:10:30Z

This pull request was exported from Phabricator. Differential Revision: D43092938

kirklandsign · 2023-02-07T20:37:29Z

/easycla

tiandiao123 · 2023-02-07T21:03:48Z

/easycla

tiandiao123 · 2023-02-07T21:17:34Z

@albanD @seemethere
hello we are updating our diff to update xnnpack, but pytorch repo onlu allows 2000 lines codes' change. But I think since we are updating our new version of xnnpack, we cannot shrink it into smaller size, could you give us an exception?

…rch#94330) Summary: Pull Request resolved: pytorch#94330 Update XNNPACK to 51a987591a6fc9f0fc0707077f53d763ac132cbf (https://github.com/google/XNNPACK/commits/51a987591a6fc9f0fc0707077f53d763ac132cbf) Update the corresponding CMake and BUCK rules, as well as the generate_wrapper.py for the new version. Due to XNNPACK having already changed a lot. We need to update XNNPACK in this time for many reasons. Firstly, XNNAPCK has updated a lot, and developers' community has re-factored codes' such as API changes. We can see from their cmakefile.txt to see there are many changes! Thus, in order to follow up upstream. We need to update xnnpack at this time. It is very crucial for our future development. Also, many projects are relying on newer versions of XNNPACK, so we probably need to update XNNPACK third-party libs at this time. we have some api changes of XNNPACK, so we also need to update them in this time. We also update target building files and generate-wrapper.py file to make this process more automatically. The original target files have some files which are missing, so we add them into buck2 building files so that it can build and test XNNPACK successfully. This commit needs to allow large files to be committed since we are updating newer xnnpack version. Test Plan: buck2 build //xplat/third-party/XNNPACK:operators buck2 build //xplat/third-party/XNNPACK:XNNPACK buck2 test fbcode//caffe2/test:xnnpack_integration Reviewed By: digantdesai Differential Revision: D43092938 fbshipit-source-id: 6fa5028544533ce40ce1b4b91d57524bc88a3f8c

facebook-github-bot · 2023-02-08T00:27:09Z

This pull request was exported from Phabricator. Differential Revision: D43092938

tiandiao123 · 2023-02-08T01:18:35Z

/easycla

tiandiao123 · 2023-02-08T06:53:31Z

@albanD @seemethere hello we are updating our diff to update xnnpack, but pytorch repo onlu allows 2000 lines codes' change. But I think since we are updating our new version of xnnpack, we cannot shrink it into smaller size, could you give us an exception?

@albanD or @seemethere

albanD · 2023-02-08T16:31:18Z

What's the difference with #94230 ? The questions there are still relevant to this PR right?

tiandiao123 · 2023-02-08T17:34:03Z

@albanD or @seemethere

that one can be closed, we actually combined 4 diffs into single one. This should be official for us @kirklandsign @digantdesai

facebook-github-bot · 2023-02-08T21:58:19Z

This pull request was exported from Phabricator. Differential Revision: D43092938

…rch#94330) Summary: Pull Request resolved: pytorch#94330 Update XNNPACK to 51a987591a6fc9f0fc0707077f53d763ac132cbf (https://github.com/google/XNNPACK/commits/51a987591a6fc9f0fc0707077f53d763ac132cbf) Update the corresponding CMake and BUCK rules, as well as the generate_wrapper.py for the new version. Due to XNNPACK having already changed a lot. We need to update XNNPACK in this time for many reasons. Firstly, XNNAPCK has updated a lot, and developers' community has re-factored codes' such as API changes. We can see from their cmakefile.txt to see there are many changes! Thus, in order to follow up upstream. We need to update xnnpack at this time. It is very crucial for our future development. Also, many projects are relying on newer versions of XNNPACK, so we probably need to update XNNPACK third-party libs at this time. we have some api changes of XNNPACK, so we also need to update them in this time. We also update target building files and generate-wrapper.py file to make this process more automatically. The original target files have some files which are missing, so we add them into buck2 building files so that it can build and test XNNPACK successfully. This commit needs to allow large files to be committed since we are updating newer xnnpack version. allow-large-files allow-large-files Test Plan: buck2 build //xplat/third-party/XNNPACK:operators buck2 build //xplat/third-party/XNNPACK:XNNPACK buck2 test fbcode//caffe2/test:xnnpack_integration Reviewed By: digantdesai Differential Revision: D43092938 fbshipit-source-id: a5134699b3998e698049bcdc4dc081eef2523ee8

albanD · 2023-02-08T22:27:38Z

Any reason why the script to generate this bzl files is not here? We could have it in our scripts/ folder to make sure we don't loose it.

Also are these bzl files used by the (open source) bazel build? FYI @vors

digantdesai

LGTM

facebook-github-bot · 2023-02-09T18:34:40Z

This pull request was exported from Phabricator. Differential Revision: D43092938

…rch#94330) Summary: Pull Request resolved: pytorch#94330 Update XNNPACK to 51a987591a6fc9f0fc0707077f53d763ac132cbf (https://github.com/google/XNNPACK/commits/51a987591a6fc9f0fc0707077f53d763ac132cbf) Update the corresponding CMake and BUCK rules, as well as the generate_wrapper.py for the new version. Due to XNNPACK having already changed a lot. We need to update XNNPACK in this time for many reasons. Firstly, XNNAPCK has updated a lot, and developers' community has re-factored codes' such as API changes. We can see from their cmakefile.txt to see there are many changes! Thus, in order to follow up upstream. We need to update xnnpack at this time. It is very crucial for our future development. Also, many projects are relying on newer versions of XNNPACK, so we probably need to update XNNPACK third-party libs at this time. we have some api changes of XNNPACK, so we also need to update them in this time. We also update target building files and generate-wrapper.py file to make this process more automatically. The original target files have some files which are missing, so we add them into buck2 building files so that it can build and test XNNPACK successfully. This commit needs to allow large files to be committed since we are updating newer xnnpack version. allow-large-files allow-large-files allow-large-files allow-large-files allow-large-files Test Plan: buck2 build //xplat/third-party/XNNPACK:operators buck2 build //xplat/third-party/XNNPACK:XNNPACK buck2 test fbcode//caffe2/test:xnnpack_integration Reviewed By: digantdesai, albanD Differential Revision: D43092938 fbshipit-source-id: 9cf2ffe79a0c03aab5da907f3ed106d6f24cae76

facebook-github-bot · 2023-02-10T07:26:13Z

This pull request was exported from Phabricator. Differential Revision: D43092938

…rch#94330) Summary: Pull Request resolved: pytorch#94330 Update XNNPACK to 51a987591a6fc9f0fc0707077f53d763ac132cbf (https://github.com/google/XNNPACK/commits/51a987591a6fc9f0fc0707077f53d763ac132cbf) Update the corresponding CMake and BUCK rules, as well as the generate_wrapper.py for the new version. Due to XNNPACK having already changed a lot. We need to update XNNPACK in this time for many reasons. Firstly, XNNAPCK has updated a lot, and developers' community has re-factored codes' such as API changes. We can see from their cmakefile.txt to see there are many changes! Thus, in order to follow up upstream. We need to update xnnpack at this time. It is very crucial for our future development. Also, many projects are relying on newer versions of XNNPACK, so we probably need to update XNNPACK third-party libs at this time. we have some api changes of XNNPACK, so we also need to update them in this time. We also update target building files and generate-wrapper.py file to make this process more automatically. The original target files have some files which are missing, so we add them into buck2 building files so that it can build and test XNNPACK successfully. This commit needs to allow large files to be committed since we are updating newer xnnpack version. allow-large-files allow-large-files allow-large-files allow-large-files allow-large-files Test Plan: buck2 build //xplat/third-party/XNNPACK:operators buck2 build //xplat/third-party/XNNPACK:XNNPACK buck2 test fbcode//caffe2/test:xnnpack_integration Reviewed By: digantdesai, albanD Differential Revision: D43092938 fbshipit-source-id: 0fdf94d11dad8ec6b6a8d3d123e0d099d6c60d16

facebook-github-bot · 2023-02-10T18:45:09Z

This pull request was exported from Phabricator. Differential Revision: D43092938

…rch#94330) Summary: Pull Request resolved: pytorch#94330 Update XNNPACK to 51a987591a6fc9f0fc0707077f53d763ac132cbf (https://github.com/google/XNNPACK/commits/51a987591a6fc9f0fc0707077f53d763ac132cbf) Update the corresponding CMake and BUCK rules, as well as the generate_wrapper.py for the new version. Due to XNNPACK having already changed a lot. We need to update XNNPACK in this time for many reasons. Firstly, XNNAPCK has updated a lot, and developers' community has re-factored codes' such as API changes. We can see from their cmakefile.txt to see there are many changes! Thus, in order to follow up upstream. We need to update xnnpack at this time. It is very crucial for our future development. Also, many projects are relying on newer versions of XNNPACK, so we probably need to update XNNPACK third-party libs at this time. we have some api changes of XNNPACK, so we also need to update them in this time. We also update target building files and generate-wrapper.py file to make this process more automatically. The original target files have some files which are missing, so we add them into buck2 building files so that it can build and test XNNPACK successfully. This commit needs to allow large files to be committed since we are updating newer xnnpack version. allow-large-files allow-large-files allow-large-files allow-large-files allow-large-files Test Plan: buck2 build //xplat/third-party/XNNPACK:operators buck2 build //xplat/third-party/XNNPACK:XNNPACK buck2 test fbcode//caffe2/test:xnnpack_integration Reviewed By: digantdesai, albanD Differential Revision: D43092938 fbshipit-source-id: 499ca3d7a4d05dc5c9f22747d7e7453da1871ced

…rch#94330) Summary: Pull Request resolved: pytorch#94330 Update XNNPACK to 51a987591a6fc9f0fc0707077f53d763ac132cbf (https://github.com/google/XNNPACK/commits/51a987591a6fc9f0fc0707077f53d763ac132cbf) Update the corresponding CMake and BUCK rules, as well as the generate_wrapper.py for the new version. Due to XNNPACK having already changed a lot. We need to update XNNPACK in this time for many reasons. Firstly, XNNAPCK has updated a lot, and developers' community has re-factored codes' such as API changes. We can see from their cmakefile.txt to see there are many changes! Thus, in order to follow up upstream. We need to update xnnpack at this time. It is very crucial for our future development. Also, many projects are relying on newer versions of XNNPACK, so we probably need to update XNNPACK third-party libs at this time. we have some api changes of XNNPACK, so we also need to update them in this time. We also update target building files and generate-wrapper.py file to make this process more automatically. The original target files have some files which are missing, so we add them into buck2 building files so that it can build and test XNNPACK successfully. This commit needs to allow large files to be committed since we are updating newer xnnpack version. allow-large-files allow-large-files allow-large-files allow-large-files allow-large-files Test Plan: buck2 build //xplat/third-party/XNNPACK:operators buck2 build //xplat/third-party/XNNPACK:XNNPACK buck2 test fbcode//caffe2/test:xnnpack_integration Reviewed By: digantdesai, albanD Differential Revision: D43092938 fbshipit-source-id: 8272634c896dae428845fc4ed16d02e12cd5591a

facebook-github-bot · 2023-02-11T03:15:44Z

This pull request was exported from Phabricator. Differential Revision: D43092938

facebook-github-bot · 2023-02-11T08:57:50Z

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

pytorchmergebot · 2023-02-11T08:59:31Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

malfet · 2023-02-13T15:17:14Z

This PR broke periodic builds, as it missed ciflow/periodic. I guess one need to update https://github.com/pytorch/pytorch/blob/master/third_party/generate-xnnpack-wrappers.py but I'm not sure if it's used correctly here

tiandiao123 · 2023-02-14T18:27:43Z

This PR broke periodic builds, as it missed ciflow/periodic. I guess one need to update https://github.com/pytorch/pytorch/blob/master/third_party/generate-xnnpack-wrappers.py but I'm not sure if it's used correctly here

we are investigating it.

Summary: Pull Request resolved: pytorch#94785 Fix CI errors for pytorch open source CI passing Here are some errors we are trying to fix: https://www.internalfb.com/phabricator/paste/view/P622309998, like some missing symbols and linking issues Test Plan: buck2 test fbcode//caffe2:test_xnnpack_delegate Differential Revision: D43259005 fbshipit-source-id: dea4b037a7dba33e382607a5d5d9dfa7e2d48db7

Summary: Pull Request resolved: pytorch#94785 Fix CI errors for pytorch open source CI passing Here are some errors we are trying to fix: https://www.internalfb.com/phabricator/paste/view/P622309998, like some missing symbols and linking issues Test Plan: buck2 test fbcode//caffe2:test_xnnpack_delegate Differential Revision: D43259005 fbshipit-source-id: 46d36345ca8d2b4b8c4031b574e33c23361729e7

Summary: Pull Request resolved: pytorch#94785 Fix CI errors for pytorch open source CI passing Here are some errors we are trying to fix: https://www.internalfb.com/phabricator/paste/view/P622309998, like some missing symbols and linking issues Test Plan: buck2 test fbcode//caffe2:test_xnnpack_delegate Differential Revision: D43259005 fbshipit-source-id: 81d30f161fa66fc74ed5e2f2ca57948f5e1caa48

Summary: we are trying to fix OSS CI caused by pytorch#94330 Pull Request resolved: pytorch#94785 Fix CI errors for pytorch open source CI passing Here are some errors we are trying to fix: https://www.internalfb.com/phabricator/paste/view/P622309998, like some missing symbols and linking issues Test Plan: buck2 test fbcode//caffe2:test_xnnpack_delegate Differential Revision: D43259005 fbshipit-source-id: e4d0a9ff6218d6732540982efa3242cbf82148b8

Summary: we are trying to fix OSS CI caused by pytorch#94330 Pull Request resolved: pytorch#94785 Fix CI errors for pytorch open source CI passing Here are some errors we are trying to fix: https://www.internalfb.com/phabricator/paste/view/P622309998, like some missing symbols and linking issues Test Plan: buck2 test fbcode//caffe2:test_xnnpack_delegate Differential Revision: D43259005 fbshipit-source-id: 045508402b1575bea17bda4d1aab3b03130bf0e9

Summary: we are trying to fix OSS CI caused by pytorch#94330 Pull Request resolved: pytorch#94785 Fix CI errors for pytorch open source CI passing Here are some errors we are trying to fix: https://www.internalfb.com/phabricator/paste/view/P622309998, like some missing symbols and linking issues Test Plan: buck2 test fbcode//caffe2:test_xnnpack_delegate Differential Revision: D43259005 fbshipit-source-id: 9bd42f6d6685367e3dd4fea2eb418f8e24397683

Summary: we are trying to fix OSS CI caused by pytorch#94330 Pull Request resolved: pytorch#94785 Fix CI errors for pytorch open source CI passing Here are some errors we are trying to fix: https://www.internalfb.com/phabricator/paste/view/P622309998, like some missing symbols and linking issues Test Plan: buck2 test fbcode//caffe2:test_xnnpack_delegate Differential Revision: D43259005 fbshipit-source-id: 612d039da557eb5818a78c41daf49c7256d1eaf6

Summary: we are trying to fix OSS CI caused by pytorch#94330 Pull Request resolved: pytorch#94785 Fix CI errors for pytorch open source CI passing Here are some errors we are trying to fix: https://www.internalfb.com/phabricator/paste/view/P622309998, like some missing symbols and linking issues Test Plan: buck2 test fbcode//caffe2:test_xnnpack_delegate Reviewed By: weiwangmeta Differential Revision: D43259005 fbshipit-source-id: df221349ffa314ade6338e9de058102942a23214

tiandiao123 requested review from jerryzh168, salilsdesai, kimishpatel, digantdesai and jianyuh as code owners February 7, 2023 20:09

pytorch-bot bot added the release notes: quantization release notes category label Feb 7, 2023

facebook-github-bot added the fb-exported label Feb 7, 2023

github-actions bot added the module: cpu CPU specific problem (e.g., perf, algorithm) label Feb 7, 2023

digantdesai added module: xnnpack and removed release notes: quantization release notes category labels Feb 7, 2023

tiandiao123 force-pushed the export-D43092938 branch from ef85136 to 6b67439 Compare February 8, 2023 00:27

github-actions bot added the release notes: quantization release notes category label Feb 8, 2023

tiandiao123 requested a review from kirklandsign February 8, 2023 01:15

tiandiao123 mentioned this pull request Feb 8, 2023

[XNNPACK] Generate new build and wrapper files #94230

Closed

tiandiao123 force-pushed the export-D43092938 branch from 6b67439 to 0eaab76 Compare February 8, 2023 21:58

albanD added the skip-pr-sanity-checks label Feb 9, 2023

digantdesai approved these changes Feb 9, 2023

View reviewed changes

albanD approved these changes Feb 9, 2023

View reviewed changes

tiandiao123 force-pushed the export-D43092938 branch from 15a465d to f52cb95 Compare February 9, 2023 18:34

tiandiao123 force-pushed the export-D43092938 branch from f52cb95 to c6b54ac Compare February 10, 2023 07:26

tiandiao123 force-pushed the export-D43092938 branch from c6b54ac to f718f49 Compare February 10, 2023 18:45

tiandiao123 force-pushed the export-D43092938 branch from f718f49 to c441e53 Compare February 11, 2023 03:15

pytorchmergebot added the Merged label Feb 11, 2023

pytorchmergebot closed this in 9dd7e83 Feb 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update xnnpack to newer version and update API usage in pytorch #94330

update xnnpack to newer version and update API usage in pytorch #94330

tiandiao123 commented Feb 7, 2023 •

edited by pytorch-bot bot

linux-foundation-easycla bot commented Feb 7, 2023 •

edited

pytorch-bot bot commented Feb 7, 2023 •

edited

facebook-github-bot commented Feb 7, 2023

kirklandsign commented Feb 7, 2023

tiandiao123 commented Feb 7, 2023

tiandiao123 commented Feb 7, 2023 •

edited

facebook-github-bot commented Feb 8, 2023

tiandiao123 commented Feb 8, 2023

tiandiao123 commented Feb 8, 2023

albanD commented Feb 8, 2023

tiandiao123 commented Feb 8, 2023

facebook-github-bot commented Feb 8, 2023

albanD commented Feb 8, 2023 •

edited

digantdesai left a comment

facebook-github-bot commented Feb 9, 2023

facebook-github-bot commented Feb 10, 2023

facebook-github-bot commented Feb 10, 2023

facebook-github-bot commented Feb 11, 2023

facebook-github-bot commented Feb 11, 2023

pytorchmergebot commented Feb 11, 2023

malfet commented Feb 13, 2023

tiandiao123 commented Feb 14, 2023

update xnnpack to newer version and update API usage in pytorch #94330

update xnnpack to newer version and update API usage in pytorch #94330

Conversation

tiandiao123 commented Feb 7, 2023 • edited by pytorch-bot bot

linux-foundation-easycla bot commented Feb 7, 2023 • edited

pytorch-bot bot commented Feb 7, 2023 • edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/94330

✅ No Failures

facebook-github-bot commented Feb 7, 2023

kirklandsign commented Feb 7, 2023

tiandiao123 commented Feb 7, 2023

tiandiao123 commented Feb 7, 2023 • edited

facebook-github-bot commented Feb 8, 2023

tiandiao123 commented Feb 8, 2023

tiandiao123 commented Feb 8, 2023

albanD commented Feb 8, 2023

tiandiao123 commented Feb 8, 2023

facebook-github-bot commented Feb 8, 2023

albanD commented Feb 8, 2023 • edited

digantdesai left a comment

Choose a reason for hiding this comment

facebook-github-bot commented Feb 9, 2023

facebook-github-bot commented Feb 10, 2023

facebook-github-bot commented Feb 10, 2023

facebook-github-bot commented Feb 11, 2023

facebook-github-bot commented Feb 11, 2023

pytorchmergebot commented Feb 11, 2023

Merge started

malfet commented Feb 13, 2023

tiandiao123 commented Feb 14, 2023

tiandiao123 commented Feb 7, 2023 •

edited by pytorch-bot bot

linux-foundation-easycla bot commented Feb 7, 2023 •

edited

pytorch-bot bot commented Feb 7, 2023 •

edited

tiandiao123 commented Feb 7, 2023 •

edited

albanD commented Feb 8, 2023 •

edited