[MPS] Fix correctness issues with Pool2D ops #94348
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add divisor to cached string key to avoid conflicts - Fallback to CPU when divisor is passed for int64 input types - Remove MaxPool2D from UNIMPLEMENTED_OP list (was put there by mistake) - Add test case when both ceil_mode and count_include_pad are True (previously failed).
* Fix issues with adaptive average and max pool2d - Warn and fallback to CPU for AdaptiveAvgPool2d if input/output sizes are not divisble - Remove the redundant blocking copies from AdaptiveMaxPool2d - Clean up redundant code * Replace warnings with TORCH_CHECK() for adaptive pooling
pytorch-bot
bot
added
ciflow/mps
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/94348
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit ad0ab28: NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
soulitzer
added
the
triaged
kulinseth
approved these changes
Feb 9, 2023
|
@pytorchbot merge -f "MPS tests are green." |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
count_include_pad=TrueAdaptiveMaxPool2ddivisorto cached string key to avoid conflictsceil_modeandcount_include_padare True (previously failed).