Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: max_unpool3d buffer overflow #94372

Closed
wants to merge 1 commit into from
Closed

fix: max_unpool3d buffer overflow #94372

wants to merge 1 commit into from

Conversation

Kristoff-starling
Copy link
Contributor

Fixes #88032

Previously output_size is accessed before the shape length check, which leads to a buffer overflow issue.

The fix is simply to prioritize the check.

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 8, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/94372

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit abe8502:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 8, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Kristoff-starling / name: Yuyao Wang (abe8502)

@Kristoff-starling
Copy link
Contributor Author

Hi, @albanD I brought a PR as we discussed in issue #88032. Could you help take a look? Thanks!

Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for taking the time to send a PR for this!
Looks great!

@albanD
Copy link
Collaborator

albanD commented Feb 8, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 8, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nn.functional.max_unpool3d Trigger heap-buffer-overflow with AddressSanitizer
4 participants