-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix scalar type resolution for optional tensor #94427
Fix scalar type resolution for optional tensor #94427
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/94427
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit f0c231c: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@pytorch merge -g |
@pytorchbot merge -g |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 2 mandatory check(s) failed (Rule Dig deeper by viewing the failures on hud Details for Dev Infra teamRaised by workflow job |
9d4b8fb
to
e54369a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Fix lint issues?
e54369a
to
f0c231c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@pytorchbot merge -f "Unrelated lint failure: python3: can't open file '/home/runner/work/pytorch/pytorch/.github/scripts/collect_ciflow_labels.py': [Errno 2] No such file or directory" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
When TorchScript Value has an optional tensor,
dtype()
orscalarType()
is not available and raise (by design).The symbolic
_op_with_optional_float_cast
must check whether the tensor is otpional or not before calling the scalar type resolution API. This PR fixes that