[pytorch] Add support for "height" and "width" dimension for the "select" operator on pytorch vulkan backend #94612

yipjustin · 2023-02-10T18:54:27Z

Summary: Add support for "height" and "width" dimension for the "select" operator on pytorch vulkan backend.

Test Plan:

yipjustin@yipjustin-mbp fbsource % buck run  -c pt.vulkan_full_precision=1  --target-platforms ovr_config//platform/macos:arm64-fbsource //xplat/caffe2:pt_vulkan_api_test_binAppleMac\#macosx-arm64 -- --gtest_filter="*select_3d*"
Downloaded 1/2 artifacts, 1.29 Mbytes, 0.0% cache miss (for updated rules)
Building: finished in 3.7 sec (100%) 450/450 jobs, 2/450 updated
  Total time: 3.8 sec
BUILD SUCCEEDED
Running main() from xplat/third-party/gmock/googletest-1.12.1/googletest/src/gtest_main.cc
Note: Google Test filter = *select_3d*
[==========] Running 9 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 9 tests from VulkanAPITest
[ RUN      ] VulkanAPITest.select_3d_depth_small
[       OK ] VulkanAPITest.select_3d_depth_small (30 ms)
[ RUN      ] VulkanAPITest.select_3d_depth_medium
[       OK ] VulkanAPITest.select_3d_depth_medium (0 ms)
[ RUN      ] VulkanAPITest.select_3d_depth_large
[       OK ] VulkanAPITest.select_3d_depth_large (1 ms)
[ RUN      ] VulkanAPITest.select_3d_height_small
[       OK ] VulkanAPITest.select_3d_height_small (0 ms)
[ RUN      ] VulkanAPITest.select_3d_height_medium
[       OK ] VulkanAPITest.select_3d_height_medium (0 ms)
[ RUN      ] VulkanAPITest.select_3d_height_large
[       OK ] VulkanAPITest.select_3d_height_large (3 ms)
[ RUN      ] VulkanAPITest.select_3d_width_small
[       OK ] VulkanAPITest.select_3d_width_small (0 ms)
[ RUN      ] VulkanAPITest.select_3d_width_medium
[       OK ] VulkanAPITest.select_3d_width_medium (0 ms)
[ RUN      ] VulkanAPITest.select_3d_width_large
[       OK ] VulkanAPITest.select_3d_width_large (1 ms)
[----------] 9 tests from VulkanAPITest (40 ms total)

[----------] Global test environment tear-down
[==========] 9 tests from 1 test suite ran. (40 ms total)
[  PASSED  ] 9 tests.

Reviewed By: SS-JIA

Differential Revision: D43020796

linux-foundation-easycla · 2023-02-10T18:54:30Z

The committers listed above are authorized under a signed CLA.

✅ login: yipjustin / name: Justin Yip (42f795a)

pytorch-bot · 2023-02-10T18:54:31Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/94612

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit bbce3e4:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2023-02-10T18:55:14Z

This pull request was exported from Phabricator. Differential Revision: D43020796

yipjustin · 2023-02-10T20:12:06Z

/easycla

facebook-github-bot · 2023-02-13T18:38:46Z

This pull request was exported from Phabricator. Differential Revision: D43020796

…ect" operator on pytorch vulkan backend (pytorch#94612) Summary: Pull Request resolved: pytorch#94612 Add support for "height" and "width" dimension for the "select" operator on pytorch vulkan backend. Test Plan: ``` yipjustin@yipjustin-mbp fbsource % buck run -c pt.vulkan_full_precision=1 --target-platforms ovr_config//platform/macos:arm64-fbsource //xplat/caffe2:pt_vulkan_api_test_binAppleMac\#macosx-arm64 -- --gtest_filter="*select_3d*" Downloaded 1/2 artifacts, 1.29 Mbytes, 0.0% cache miss (for updated rules) Building: finished in 3.7 sec (100%) 450/450 jobs, 2/450 updated Total time: 3.8 sec BUILD SUCCEEDED Running main() from xplat/third-party/gmock/googletest-1.12.1/googletest/src/gtest_main.cc Note: Google Test filter = *select_3d* [==========] Running 9 tests from 1 test suite. [----------] Global test environment set-up. [----------] 9 tests from VulkanAPITest [ RUN ] VulkanAPITest.select_3d_depth_small [ OK ] VulkanAPITest.select_3d_depth_small (30 ms) [ RUN ] VulkanAPITest.select_3d_depth_medium [ OK ] VulkanAPITest.select_3d_depth_medium (0 ms) [ RUN ] VulkanAPITest.select_3d_depth_large [ OK ] VulkanAPITest.select_3d_depth_large (1 ms) [ RUN ] VulkanAPITest.select_3d_height_small [ OK ] VulkanAPITest.select_3d_height_small (0 ms) [ RUN ] VulkanAPITest.select_3d_height_medium [ OK ] VulkanAPITest.select_3d_height_medium (0 ms) [ RUN ] VulkanAPITest.select_3d_height_large [ OK ] VulkanAPITest.select_3d_height_large (3 ms) [ RUN ] VulkanAPITest.select_3d_width_small [ OK ] VulkanAPITest.select_3d_width_small (0 ms) [ RUN ] VulkanAPITest.select_3d_width_medium [ OK ] VulkanAPITest.select_3d_width_medium (0 ms) [ RUN ] VulkanAPITest.select_3d_width_large [ OK ] VulkanAPITest.select_3d_width_large (1 ms) [----------] 9 tests from VulkanAPITest (40 ms total) [----------] Global test environment tear-down [==========] 9 tests from 1 test suite ran. (40 ms total) [ PASSED ] 9 tests. ``` Reviewed By: SS-JIA Differential Revision: D43020796 fbshipit-source-id: 671244d73ec8ee2339d9a8856a7d84f812f0b3eb

yipjustin · 2023-02-13T19:16:02Z

/easycla

facebook-github-bot · 2023-02-13T20:24:39Z

This pull request was exported from Phabricator. Differential Revision: D43020796

…ect" operator on pytorch vulkan backend (pytorch#94612) Summary: Pull Request resolved: pytorch#94612 Add support for "height" and "width" dimension for the "select" operator on pytorch vulkan backend. Test Plan: ``` yipjustin@yipjustin-mbp fbsource % buck run -c pt.vulkan_full_precision=1 --target-platforms ovr_config//platform/macos:arm64-fbsource //xplat/caffe2:pt_vulkan_api_test_binAppleMac\#macosx-arm64 -- --gtest_filter="*select_3d*" Downloaded 1/2 artifacts, 1.29 Mbytes, 0.0% cache miss (for updated rules) Building: finished in 3.7 sec (100%) 450/450 jobs, 2/450 updated Total time: 3.8 sec BUILD SUCCEEDED Running main() from xplat/third-party/gmock/googletest-1.12.1/googletest/src/gtest_main.cc Note: Google Test filter = *select_3d* [==========] Running 9 tests from 1 test suite. [----------] Global test environment set-up. [----------] 9 tests from VulkanAPITest [ RUN ] VulkanAPITest.select_3d_depth_small [ OK ] VulkanAPITest.select_3d_depth_small (30 ms) [ RUN ] VulkanAPITest.select_3d_depth_medium [ OK ] VulkanAPITest.select_3d_depth_medium (0 ms) [ RUN ] VulkanAPITest.select_3d_depth_large [ OK ] VulkanAPITest.select_3d_depth_large (1 ms) [ RUN ] VulkanAPITest.select_3d_height_small [ OK ] VulkanAPITest.select_3d_height_small (0 ms) [ RUN ] VulkanAPITest.select_3d_height_medium [ OK ] VulkanAPITest.select_3d_height_medium (0 ms) [ RUN ] VulkanAPITest.select_3d_height_large [ OK ] VulkanAPITest.select_3d_height_large (3 ms) [ RUN ] VulkanAPITest.select_3d_width_small [ OK ] VulkanAPITest.select_3d_width_small (0 ms) [ RUN ] VulkanAPITest.select_3d_width_medium [ OK ] VulkanAPITest.select_3d_width_medium (0 ms) [ RUN ] VulkanAPITest.select_3d_width_large [ OK ] VulkanAPITest.select_3d_width_large (1 ms) [----------] 9 tests from VulkanAPITest (40 ms total) [----------] Global test environment tear-down [==========] 9 tests from 1 test suite ran. (40 ms total) [ PASSED ] 9 tests. ``` Reviewed By: SS-JIA Differential Revision: D43020796 fbshipit-source-id: 7cf725e07e8ae5b898a6fe951a00cecf34f133ce

facebook-github-bot · 2023-02-14T01:28:32Z

@yipjustin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

yipjustin · 2023-02-14T17:49:22Z

@pytorchbot merge

pytorchmergebot · 2023-02-14T17:51:07Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2023-02-14T19:17:20Z

Merge failed

Reason: 1 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_8-cuda11_7-with-pypi-cudnn-test / test

Details for Dev Infra team

Raised by workflow job

yipjustin · 2023-02-14T23:31:10Z

Ignoring the two failures as they are unlikely to be related to this change. @SS-JIA

@pytorchbot merge -f

pytorch-bot · 2023-02-14T23:31:12Z

❌ 🤖 pytorchbot command failed:

@pytorchbot merge: error: argument -f/--force: expected one argument

usage: @pytorchbot merge [-g | -f MESSAGE | -l] [-r [{viable/strict,master}]]

Try @pytorchbot --help for more info.

yipjustin · 2023-02-14T23:31:53Z

@pytorchmergebot merge -f "Ignoring the two failures as they are unlikely to be related to this change."

pytorch-bot · 2023-02-14T23:31:56Z

You are not authorized to force merges to this repository. Please use the regular @pytorchmergebot merge command instead

yipjustin · 2023-02-14T23:33:06Z

@pytorchmergebot merge -f "Ignoring the two failures as they are unlikely to be related to this change."

pytorch-bot · 2023-02-14T23:33:09Z

You are not authorized to force merges to this repository. Please use the regular @pytorchmergebot merge command instead

yipjustin · 2023-02-15T02:04:34Z

@pytorchbot rebase

pytorch-bot · 2023-02-15T02:04:38Z

You don't have permissions to rebase this PR since you are a first time contributor. If you think this is a mistake, please contact PyTorch Dev Infra.

huydhn · 2023-02-15T03:22:04Z

@pytorchbot rebase

pytorchmergebot · 2023-02-15T03:23:59Z

@pytorchbot successfully started a rebase job. Check the current status here

…ect" operator on pytorch vulkan backend (pytorch#94612) Summary: Pull Request resolved: pytorch#94612 Add support for "height" and "width" dimension for the "select" operator on pytorch vulkan backend. Test Plan: ``` yipjustin@yipjustin-mbp fbsource % buck run -c pt.vulkan_full_precision=1 --target-platforms ovr_config//platform/macos:arm64-fbsource //xplat/caffe2:pt_vulkan_api_test_binAppleMac\#macosx-arm64 -- --gtest_filter="*select_3d*" Downloaded 1/2 artifacts, 1.29 Mbytes, 0.0% cache miss (for updated rules) Building: finished in 3.7 sec (100%) 450/450 jobs, 2/450 updated Total time: 3.8 sec BUILD SUCCEEDED Running main() from xplat/third-party/gmock/googletest-1.12.1/googletest/src/gtest_main.cc Note: Google Test filter = *select_3d* [==========] Running 9 tests from 1 test suite. [----------] Global test environment set-up. [----------] 9 tests from VulkanAPITest [ RUN ] VulkanAPITest.select_3d_depth_small [ OK ] VulkanAPITest.select_3d_depth_small (30 ms) [ RUN ] VulkanAPITest.select_3d_depth_medium [ OK ] VulkanAPITest.select_3d_depth_medium (0 ms) [ RUN ] VulkanAPITest.select_3d_depth_large [ OK ] VulkanAPITest.select_3d_depth_large (1 ms) [ RUN ] VulkanAPITest.select_3d_height_small [ OK ] VulkanAPITest.select_3d_height_small (0 ms) [ RUN ] VulkanAPITest.select_3d_height_medium [ OK ] VulkanAPITest.select_3d_height_medium (0 ms) [ RUN ] VulkanAPITest.select_3d_height_large [ OK ] VulkanAPITest.select_3d_height_large (3 ms) [ RUN ] VulkanAPITest.select_3d_width_small [ OK ] VulkanAPITest.select_3d_width_small (0 ms) [ RUN ] VulkanAPITest.select_3d_width_medium [ OK ] VulkanAPITest.select_3d_width_medium (0 ms) [ RUN ] VulkanAPITest.select_3d_width_large [ OK ] VulkanAPITest.select_3d_width_large (1 ms) [----------] 9 tests from VulkanAPITest (40 ms total) [----------] Global test environment tear-down [==========] 9 tests from 1 test suite ran. (40 ms total) [ PASSED ] 9 tests. ``` Reviewed By: SS-JIA Differential Revision: D43020796 fbshipit-source-id: 7cf725e07e8ae5b898a6fe951a00cecf34f133ce

pytorchmergebot · 2023-02-15T03:24:04Z

Successfully rebased export-D43020796 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout export-D43020796 && git pull --rebase)

facebook-github-bot · 2023-02-15T04:09:58Z

@yipjustin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

yipjustin · 2023-02-15T19:13:21Z

@pytorchbot merge

pytorchmergebot · 2023-02-15T19:15:07Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

…ect" operator on pytorch vulkan backend (pytorch#94612) Summary: Add support for "height" and "width" dimension for the "select" operator on pytorch vulkan backend. Test Plan: ``` yipjustin@yipjustin-mbp fbsource % buck run -c pt.vulkan_full_precision=1 --target-platforms ovr_config//platform/macos:arm64-fbsource //xplat/caffe2:pt_vulkan_api_test_binAppleMac\#macosx-arm64 -- --gtest_filter="*select_3d*" Downloaded 1/2 artifacts, 1.29 Mbytes, 0.0% cache miss (for updated rules) Building: finished in 3.7 sec (100%) 450/450 jobs, 2/450 updated Total time: 3.8 sec BUILD SUCCEEDED Running main() from xplat/third-party/gmock/googletest-1.12.1/googletest/src/gtest_main.cc Note: Google Test filter = *select_3d* [==========] Running 9 tests from 1 test suite. [----------] Global test environment set-up. [----------] 9 tests from VulkanAPITest [ RUN ] VulkanAPITest.select_3d_depth_small [ OK ] VulkanAPITest.select_3d_depth_small (30 ms) [ RUN ] VulkanAPITest.select_3d_depth_medium [ OK ] VulkanAPITest.select_3d_depth_medium (0 ms) [ RUN ] VulkanAPITest.select_3d_depth_large [ OK ] VulkanAPITest.select_3d_depth_large (1 ms) [ RUN ] VulkanAPITest.select_3d_height_small [ OK ] VulkanAPITest.select_3d_height_small (0 ms) [ RUN ] VulkanAPITest.select_3d_height_medium [ OK ] VulkanAPITest.select_3d_height_medium (0 ms) [ RUN ] VulkanAPITest.select_3d_height_large [ OK ] VulkanAPITest.select_3d_height_large (3 ms) [ RUN ] VulkanAPITest.select_3d_width_small [ OK ] VulkanAPITest.select_3d_width_small (0 ms) [ RUN ] VulkanAPITest.select_3d_width_medium [ OK ] VulkanAPITest.select_3d_width_medium (0 ms) [ RUN ] VulkanAPITest.select_3d_width_large [ OK ] VulkanAPITest.select_3d_width_large (1 ms) [----------] 9 tests from VulkanAPITest (40 ms total) [----------] Global test environment tear-down [==========] 9 tests from 1 test suite ran. (40 ms total) [ PASSED ] 9 tests. ``` Reviewed By: SS-JIA Differential Revision: D43020796 Pull Request resolved: pytorch#94612 Approved by: https://github.com/SS-JIA

…the "select" operator on pytorch vulkan backend (pytorch#94612)" This reverts commit f2c2642.

…ect" operator on pytorch vulkan backend (pytorch#94612) Summary: Add support for "height" and "width" dimension for the "select" operator on pytorch vulkan backend. Test Plan: ``` yipjustin@yipjustin-mbp fbsource % buck run -c pt.vulkan_full_precision=1 --target-platforms ovr_config//platform/macos:arm64-fbsource //xplat/caffe2:pt_vulkan_api_test_binAppleMac\#macosx-arm64 -- --gtest_filter="*select_3d*" Downloaded 1/2 artifacts, 1.29 Mbytes, 0.0% cache miss (for updated rules) Building: finished in 3.7 sec (100%) 450/450 jobs, 2/450 updated Total time: 3.8 sec BUILD SUCCEEDED Running main() from xplat/third-party/gmock/googletest-1.12.1/googletest/src/gtest_main.cc Note: Google Test filter = *select_3d* [==========] Running 9 tests from 1 test suite. [----------] Global test environment set-up. [----------] 9 tests from VulkanAPITest [ RUN ] VulkanAPITest.select_3d_depth_small [ OK ] VulkanAPITest.select_3d_depth_small (30 ms) [ RUN ] VulkanAPITest.select_3d_depth_medium [ OK ] VulkanAPITest.select_3d_depth_medium (0 ms) [ RUN ] VulkanAPITest.select_3d_depth_large [ OK ] VulkanAPITest.select_3d_depth_large (1 ms) [ RUN ] VulkanAPITest.select_3d_height_small [ OK ] VulkanAPITest.select_3d_height_small (0 ms) [ RUN ] VulkanAPITest.select_3d_height_medium [ OK ] VulkanAPITest.select_3d_height_medium (0 ms) [ RUN ] VulkanAPITest.select_3d_height_large [ OK ] VulkanAPITest.select_3d_height_large (3 ms) [ RUN ] VulkanAPITest.select_3d_width_small [ OK ] VulkanAPITest.select_3d_width_small (0 ms) [ RUN ] VulkanAPITest.select_3d_width_medium [ OK ] VulkanAPITest.select_3d_width_medium (0 ms) [ RUN ] VulkanAPITest.select_3d_width_large [ OK ] VulkanAPITest.select_3d_width_large (1 ms) [----------] 9 tests from VulkanAPITest (40 ms total) [----------] Global test environment tear-down [==========] 9 tests from 1 test suite ran. (40 ms total) [ PASSED ] 9 tests. ``` Reviewed By: SS-JIA Differential Revision: D43020796 Pull Request resolved: pytorch#94612 Approved by: https://github.com/SS-JIA

pytorch-bot bot added the release notes: vulkan release notes category label Feb 10, 2023

facebook-github-bot added the fb-exported label Feb 10, 2023

SS-JIA approved these changes Feb 10, 2023

View reviewed changes

yipjustin force-pushed the export-D43020796 branch from e6890ea to 42f795a Compare February 13, 2023 18:38

yipjustin force-pushed the export-D43020796 branch from 42f795a to 79927f3 Compare February 13, 2023 20:24

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 14, 2023

pytorchmergebot force-pushed the export-D43020796 branch from 79927f3 to bbce3e4 Compare February 15, 2023 03:24

pytorchmergebot added the Merged label Feb 15, 2023

pytorchmergebot closed this in f2c2642 Feb 15, 2023

msaroufim mentioned this pull request Mar 3, 2023

Remove mention of dynamo.optimize() in docs #96002

Closed

pruthvistony added a commit to ROCm/pytorch that referenced this pull request May 2, 2023

Revert "[pytorch] Add support for "height" and "width" dimension for …

1a686de

…the "select" operator on pytorch vulkan backend (pytorch#94612)" This reverts commit f2c2642.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[pytorch] Add support for "height" and "width" dimension for the "select" operator on pytorch vulkan backend #94612

[pytorch] Add support for "height" and "width" dimension for the "select" operator on pytorch vulkan backend #94612

yipjustin commented Feb 10, 2023

linux-foundation-easycla bot commented Feb 10, 2023 •

edited

pytorch-bot bot commented Feb 10, 2023 •

edited

facebook-github-bot commented Feb 10, 2023

yipjustin commented Feb 10, 2023

facebook-github-bot commented Feb 13, 2023

yipjustin commented Feb 13, 2023

facebook-github-bot commented Feb 13, 2023

facebook-github-bot commented Feb 14, 2023

yipjustin commented Feb 14, 2023

pytorchmergebot commented Feb 14, 2023

pytorchmergebot commented Feb 14, 2023

yipjustin commented Feb 14, 2023

pytorch-bot bot commented Feb 14, 2023

yipjustin commented Feb 14, 2023 •

edited

pytorch-bot bot commented Feb 14, 2023

yipjustin commented Feb 14, 2023

pytorch-bot bot commented Feb 14, 2023

yipjustin commented Feb 15, 2023

pytorch-bot bot commented Feb 15, 2023

huydhn commented Feb 15, 2023

pytorchmergebot commented Feb 15, 2023

pytorchmergebot commented Feb 15, 2023

facebook-github-bot commented Feb 15, 2023

yipjustin commented Feb 15, 2023

pytorchmergebot commented Feb 15, 2023

[pytorch] Add support for "height" and "width" dimension for the "select" operator on pytorch vulkan backend #94612

[pytorch] Add support for "height" and "width" dimension for the "select" operator on pytorch vulkan backend #94612

Conversation

yipjustin commented Feb 10, 2023

linux-foundation-easycla bot commented Feb 10, 2023 • edited

pytorch-bot bot commented Feb 10, 2023 • edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/94612

✅ No Failures

facebook-github-bot commented Feb 10, 2023

yipjustin commented Feb 10, 2023

facebook-github-bot commented Feb 13, 2023

yipjustin commented Feb 13, 2023

facebook-github-bot commented Feb 13, 2023

facebook-github-bot commented Feb 14, 2023

yipjustin commented Feb 14, 2023

pytorchmergebot commented Feb 14, 2023

Merge started

pytorchmergebot commented Feb 14, 2023

Merge failed

yipjustin commented Feb 14, 2023

pytorch-bot bot commented Feb 14, 2023

yipjustin commented Feb 14, 2023 • edited

pytorch-bot bot commented Feb 14, 2023

yipjustin commented Feb 14, 2023

pytorch-bot bot commented Feb 14, 2023

yipjustin commented Feb 15, 2023

pytorch-bot bot commented Feb 15, 2023

huydhn commented Feb 15, 2023

pytorchmergebot commented Feb 15, 2023

pytorchmergebot commented Feb 15, 2023

facebook-github-bot commented Feb 15, 2023

yipjustin commented Feb 15, 2023

pytorchmergebot commented Feb 15, 2023

Merge started

linux-foundation-easycla bot commented Feb 10, 2023 •

edited

pytorch-bot bot commented Feb 10, 2023 •

edited

yipjustin commented Feb 14, 2023 •

edited