Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ONNX] Reduce 'find_mismatch' memory footprint by promptly freeing past sessions. #94648

Closed
wants to merge 1 commit into from
Closed

[ONNX] Reduce 'find_mismatch' memory footprint by promptly freeing past sessions. #94648

wants to merge 1 commit into from

Conversation

BowenBao
Copy link
Collaborator

@BowenBao BowenBao commented Feb 11, 2023 •
edited

@BowenBao BowenBao requested a review from abock as a code owner February 11, 2023 01:50
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 11, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/94648

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 Failures

As of commit 6915eb7:

BROKEN TRUNK - The following jobs failed but were present on the merge base c1c7eaf:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Feb 11, 2023
BowenBao added a commit that referenced this pull request Feb 11, 2023
@BowenBao
[ONNX] Reduce 'find_mismatch' memory footprint by promptly freeing pa…
fa0ab1f 
…st sessions.

ghstack-source-id: 63f0609b377466c2cc79122ae4ce299723a260f8
Pull Request resolved: #94648
@BowenBao BowenBao added topic: improvements topic category module: onnx Related to torch.onnx labels Feb 11, 2023
@BowenBao
Copy link
Collaborator Author

cc @souptc

@BowenBao
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 11, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 5 jobs have failed, first few of them are: trunk / macos-12-py3-arm64 / test (default, 1, 2, macos-m1-12), trunk / macos-12-py3-arm64 / test (default, 2, 2, macos-m1-12), trunk / macos-12-py3-x86-64 / test (default, 1, 3, macos-12), trunk / macos-12-py3-x86-64 / test (default, 2, 3, macos-12), trunk / macos-12-py3-x86-64 / test (default, 3, 3, macos-12)

Details for Dev Infra team Raised by workflow job

@BowenBao
Copy link
Collaborator Author

@pytorchbot merge -f "unrelated failures. Broken in base."

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/BowenBao/196/head branch June 8, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinchuby justinchuby justinchuby approved these changes

@abock abock Awaiting requested review from abock

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: improvements topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BowenBao @pytorchmergebot @justinchuby @pytorchbot