Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPS] Add scatter gather kernels (support up to 5 dimensions) #94663

Closed

Conversation

DenisVieriu97
Copy link
Collaborator

Add scatter gather kernels (support up to 5 dimensions)

  • Fixes int64 issues for mH, mT, T, H on Monterey

@DenisVieriu97 DenisVieriu97 added the ciflow/mps Run MPS tests (subset of trunk) label Feb 11, 2023
@pytorch-bot pytorch-bot bot added the release notes: mps Release notes category label Feb 11, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 11, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/94663

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d73c1da:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

DenisVieriu97 and others added 3 commits February 11, 2023 14:34
* Add scatter gather kernels (support up to 5 dimensions)

* Remove duplicate code

* Return gather output directly if dst is contiguous

* Fix cast gather scatter test

* Address PR comments

* Address PR comments
@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 12, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: New commits were pushed while merging. Please rerun the merge command.

Details for Dev Infra team Raised by workflow job

@DenisVieriu97
Copy link
Collaborator Author

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

brkirch added a commit to brkirch/pytorch that referenced this pull request Apr 4, 2023
…pytorch#94663)"

The new scatter gather kernels result in ~5% reduced performance during inference with Stable Diffusion.
brkirch added a commit to brkirch/pytorch that referenced this pull request Apr 4, 2023
brkirch added a commit to brkirch/pytorch that referenced this pull request Apr 8, 2023
brkirch added a commit to brkirch/pytorch that referenced this pull request Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: mps Release notes category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants