-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MPS] Fix batch norm for NHWC #94760
Conversation
* Fix batch norm NHWC case * Fix build * Fix remaining failures
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/94760
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3982950: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
helper((4, 5, 9, 8), 2, (4, 5, 13, 8), (4, 5, 13, 8), reduce_str=reduce) | ||
helper((4, 5, 9, 8), 2, (3, 4, 10, 6), (3, 4, 10, 6), reduce_str=reduce) | ||
helper((4, 5, 9, 8), 2, (3, 3, 7, 5), (3, 4, 10, 6), reduce_str=reduce) | ||
for reduce_type in ["add", "multiply"]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using reduce
for a variable conflicts with the reduce
module from python
@pytorchbot merge -g |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Fixes
test_modules.py
batch norm NHWC testcases:test_memory_format_nn_BatchNorm2d_eval_mode_mps_float32
test_memory_format_nn_BatchNorm2d_eval_mode_mps_float32