Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add backwards for gelu and relu on nested tensors. #94776

Closed
wants to merge 1 commit into from
Closed

add backwards for gelu and relu on nested tensors. #94776

wants to merge 1 commit into from

Conversation

drisspg
Copy link
Contributor

@drisspg drisspg commented Feb 13, 2023 •
edited by pytorch-bot bot

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 13, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/94776

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6d7686c:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@drisspg drisspg force-pushed the regsiter_epilogue_backwards_nested_tenosr branch from 7f4eff3 to 6982912 Compare February 13, 2023 23:58
@drisspg
Copy link
Contributor Author

drisspg commented Feb 14, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 14, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 42 mandatory check(s) failed (Rule superuser). The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@drisspg drisspg added module: nestedtensor NestedTensor tag see issue #25032 release notes: nested tensor Changes that have a direct impact on nested tensors labels Feb 14, 2023
@drisspg
Copy link
Contributor Author

drisspg commented Feb 14, 2023

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased regsiter_epilogue_backwards_nested_tenosr onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout regsiter_epilogue_backwards_nested_tenosr && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the regsiter_epilogue_backwards_nested_tenosr branch from 6982912 to 6d7686c Compare February 14, 2023 15:16
@drisspg
Copy link
Contributor Author

drisspg commented Feb 14, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpuhrsch cpuhrsch cpuhrsch approved these changes

@mikaylagawarecki mikaylagawarecki Awaiting requested review from mikaylagawarecki

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: nestedtensor NestedTensor tag see issue #25032 release notes: nested tensor Changes that have a direct impact on nested tensors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nn.ReLU and nn.GELU backward ops not implemented for nested_tensor
3 participants
@drisspg @pytorchmergebot @cpuhrsch