Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1/n] Add verifier for EXIR Aten dialect #94783

Closed
wants to merge 1 commit into from
Closed

[1/n] Add verifier for EXIR Aten dialect #94783

wants to merge 1 commit into from

Conversation

qihqi
Copy link
Contributor

@qihqi qihqi commented Feb 14, 2023

Fixes #ISSUE_NUMBER

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 14, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/94783

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b203ef0:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: fx release notes category label Feb 14, 2023
@zhxchen17
Copy link
Contributor

I'm okay with the change in general.

zhxchen17
zhxchen17 reviewed Feb 14, 2023
View reviewed changes
test/fx/test_verifier.py Outdated

class VerifierTest(TestCase):

def test_exir_verifier(self) -> None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to mention exir? I feel like it's just an internal name, but when published we should have a different name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. removed all mentions to exir.

@qihqi qihqi requested a review from zhxchen17 February 15, 2023 21:18
@qihqi qihqi force-pushed the verifier branch 7 times, most recently from e386ca1 to bfde8ad Compare February 17, 2023 01:03
@zhxchen17
Copy link
Contributor

cc @SherlockNoMad

@qihqi
Copy link
Contributor Author

qihqi commented Feb 23, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 23, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR is too stale; the last push date was more than 3 days ago. Please rebase and try again. You can rebase by leaving the following comment on this PR:
@pytorchbot rebase

Details for Dev Infra team Raised by workflow job

@qihqi
Copy link
Contributor Author

qihqi commented Feb 24, 2023

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased verifier onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout verifier && git pull --rebase)

@qihqi
Copy link
Contributor Author

qihqi commented Feb 28, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot.

@qihqi
Add verifier for EXIR Aten dialect.
b203ef0 
Summary:

Test Plan:
Unittest

Reviewers:

Subscribers:

Tasks:

Tags:
@qihqi
Copy link
Contributor Author

qihqi commented Mar 8, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

ydwu4 pushed a commit to ydwu4/pytorch that referenced this pull request Mar 10, 2023
@qihqi @ydwu4
[1/n] Add verifier for EXIR Aten dialect (pytorch#94783)
a4915b9 
Fixes #ISSUE_NUMBER

Pull Request resolved: pytorch#94783
Approved by: https://github.com/zhxchen17
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 12, 2023
@qihqi @cyyever
[1/n] Add verifier for EXIR Aten dialect (#94783)
8b50f3e 
Fixes #ISSUE_NUMBER

Pull Request resolved: pytorch/pytorch#94783
Approved by: https://github.com/zhxchen17
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 12, 2023
@qihqi @cyyever
[1/n] Add verifier for EXIR Aten dialect (#94783)
8488bf2 
Fixes #ISSUE_NUMBER

Pull Request resolved: pytorch/pytorch#94783
Approved by: https://github.com/zhxchen17
ydwu4 added a commit to ydwu4/pytorch that referenced this pull request Mar 13, 2023
@ydwu4
[1/n] Add verifier for EXIR Aten dialect (pytorch#94783)
f58fd04 
Fixes #ISSUE_NUMBER

Pull Request resolved: pytorch#94783
Approved by: https://github.com/zhxchen17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhxchen17 zhxchen17 zhxchen17 approved these changes

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: fx release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@qihqi @zhxchen17 @pytorchmergebot