Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug fix] sparse_mask: wrong intersection on CUDA #94829

Closed
wants to merge 2 commits into from
Closed

[Bug fix] sparse_mask: wrong intersection on CUDA #94829

wants to merge 2 commits into from

Conversation

nikitaved
Copy link
Collaborator

@nikitaved nikitaved commented Feb 14, 2023 •
edited by pytorch-bot bot

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 14, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/94829

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 59a4da0:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

nikitaved added a commit that referenced this pull request Feb 14, 2023
@nikitaved
[Bug fix] sparse_mask: wrong intersection on CUDA
53099e6 
ghstack-source-id: 442943b4a9c173042ec7c530d553e19415c9d1c9
Pull Request resolved: #94829
@nikitaved nikitaved added module: sparse Related to torch.sparse release notes: sparse release notes category labels Feb 14, 2023
@nikitaved
Copy link
Collaborator Author

The bug is serious, but, luckily, the fix is simple and overall an oversight from my side.

@nikitaved nikitaved added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 14, 2023
@nikitaved
Copy link
Collaborator Author

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / win-vs2019-cuda11.7-py3 / test (default, 3, 5, windows.g5.4xlarge.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

@nikitaved
Update on "[Bug fix] sparse_mask: wrong intersection on CUDA"
59a4da0 
cc alexsamardzic pearu cpuhrsch amjames bhosmer

[ghstack-poisoned]
nikitaved added a commit that referenced this pull request Feb 15, 2023
@nikitaved
[Bug fix] sparse_mask: wrong intersection on CUDA
d34227c 
ghstack-source-id: b6817a866510d25de77695631dbce6bb81155b9e
Pull Request resolved: #94829
@nikitaved
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/nikitaved/22/head branch June 8, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpuhrsch cpuhrsch cpuhrsch approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: sparse Related to torch.sparse open source release notes: sparse release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nikitaved @pytorchmergebot @cpuhrsch @pytorchbot