Hard code known true contiguity settings for unbacked SymInts #95003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracted from #94523 which has E2E test Signed-off-by: Edward Z. Yang <ezyang@meta.com> [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95003
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 99e25b2: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
github-actions
bot
requested review from
albanD,
antoniojkim,
bdhirsh,
Chillee,
jbschlosser,
miladm,
SherlockNoMad,
voznesenskym and
wconstab
| @@ -1212,6 +1212,27 @@ void TensorImpl::empty_tensor_restride_symint(MemoryFormat memory_format) { | |||
| // recompute contiguous flag, as currently NHWC/NCHW flags are not mutually | |||
| // exclusive see #24090 | |||
| refresh_contiguous(); | |||
| // hard code some known true settings, for unbacked case | |||
| // TODO: avoid chundering into the guards for computing these | |||
| switch (memory_format) { | |||
There was a problem hiding this comment.
if you don't set true, do they default false?
There was a problem hiding this comment.
no, they would be set to some complicated expression from the guard-less bool implementation that would evaluate to true (often, sympy cannot figure it out though)
voznesenskym
approved these changes
Feb 16, 2023
ngimel
approved these changes
Feb 16, 2023
…nts" Extracted from #94523 which has E2E test Signed-off-by: Edward Z. Yang <ezyangmeta.com> [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pruthvistony
added a commit
to ROCm/pytorch
that referenced
this pull request
May 2, 2023
…pytorch#95003)" This reverts commit d9950c5.
jhavukainen
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Mar 15, 2024
…h#95003) Extracted from pytorch#94523 which has E2E test Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: pytorch#95003 Approved by: https://github.com/voznesenskym, https://github.com/ngimel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Extracted from #94523 which has E2E test
Signed-off-by: Edward Z. Yang ezyang@meta.com