Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[meta_tensor] polish error strings in meta registrations #95052

Closed
wants to merge 1 commit into from
Closed

[meta_tensor] polish error strings in meta registrations #95052

wants to merge 1 commit into from

Conversation

1SAA
Copy link
Contributor

@1SAA 1SAA commented Feb 17, 2023

I found some error message should be formatted for detailed information. So I polished those error message.

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 17, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95052

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 0def79f:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 17, 2023 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: 1SAA / name: HELSON (ca36d52)

bdhirsh
bdhirsh approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@bdhirsh bdhirsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bdhirsh
Copy link
Contributor

bdhirsh commented Feb 22, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 22, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR is too stale; the last push date was more than 3 days ago. Please rebase and try again. You can rebase by leaving the following comment on this PR:
@pytorchbot rebase

Details for Dev Infra team Raised by workflow job

@bdhirsh
Copy link
Contributor

bdhirsh commented Feb 22, 2023

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased my_dev onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout my_dev && git pull --rebase)

@bdhirsh
Copy link
Contributor

bdhirsh commented Feb 23, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: Check Labels / Check labels

Details for Dev Infra team Raised by workflow job

@bdhirsh bdhirsh added the release notes: composability release notes category label Feb 27, 2023
@bdhirsh
Copy link
Contributor

bdhirsh commented Feb 27, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR is too stale; the last push date was more than 3 days ago. Please rebase and try again. You can rebase by leaving the following comment on this PR:
@pytorchbot rebase

Details for Dev Infra team Raised by workflow job

@bdhirsh
Copy link
Contributor

bdhirsh commented Feb 27, 2023

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased my_dev onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout my_dev && git pull --rebase)

@bdhirsh
Copy link
Contributor

bdhirsh commented Feb 27, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 1, 2023
@1SAA @cyyever
[meta_tensor] polish error strings in meta registrations (#95052)
f51d6f7 
I found some error message should be formatted for detailed information. So I polished those error message.
Pull Request resolved: pytorch/pytorch#95052
Approved by: https://github.com/bdhirsh
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 2, 2023
@1SAA @cyyever
[meta_tensor] polish error strings in meta registrations (#95052)
21cd26f 
I found some error message should be formatted for detailed information. So I polished those error message.
Pull Request resolved: pytorch/pytorch#95052
Approved by: https://github.com/bdhirsh
@msaroufim msaroufim mentioned this pull request Mar 3, 2023
Closed
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 5, 2023
@1SAA @cyyever
[meta_tensor] polish error strings in meta registrations (#95052)
ea4b9c7 
I found some error message should be formatted for detailed information. So I polished those error message.
Pull Request resolved: pytorch/pytorch#95052
Approved by: https://github.com/bdhirsh
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 5, 2023
@1SAA @cyyever
[meta_tensor] polish error strings in meta registrations (#95052)
6dd1d5c 
I found some error message should be formatted for detailed information. So I polished those error message.
Pull Request resolved: pytorch/pytorch#95052
Approved by: https://github.com/bdhirsh
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 27, 2023
@1SAA @cyyever
[meta_tensor] polish error strings in meta registrations (#95052)
ad49b3f 
I found some error message should be formatted for detailed information. So I polished those error message.
Pull Request resolved: pytorch/pytorch#95052
Approved by: https://github.com/bdhirsh
pruthvistony added a commit to ROCm/pytorch that referenced this pull request May 2, 2023
@pruthvistony
Revert "[meta_tensor] polish error strings in meta registrations (pyt…
5b073be 
…orch#95052)"

This reverts commit f43ce95.
jhavukainen pushed a commit to kulinseth/pytorch that referenced this pull request Mar 15, 2024
@1SAA @jhavukainen
[meta_tensor] polish error strings in meta registrations (pytorch#95052)
5422cbb 
I found some error message should be formatted for detailed information. So I polished those error message.
Pull Request resolved: pytorch#95052
Approved by: https://github.com/bdhirsh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdhirsh bdhirsh bdhirsh approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: composability release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@1SAA @bdhirsh @pytorchmergebot @pytorchbot