[MPS] Add optional minor argument to is_macos13_or_newer
#95065
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will be needed if one wants to make accurate XFAIL validation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95065
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 751e9a5: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/mps
|
@pytorchbot merge -f "MPS tests are green" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pruthvistony
added a commit
to ROCm/pytorch
that referenced
this pull request
May 2, 2023
…ytorch#95065)" This reverts commit 5de3ead.
jhavukainen
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Mar 15, 2024
…#95065) Will be needed if one wants to make accurate XFAIL validation I.e. `torch.backends.mps.is_macos13_or_newer()` will return True if PyTorch is running on MacOS 13.0 or newer, `torch.backends.mps.is_macos13_or_newer(1)` will return True if running on MacOS 13.1 or newer and `torch.backends.mps.is_macos13_or_newer(2)` will return True if running on MacOS 13.2 or newer Do not use 13.3 check as `@available` does not really work for shared libraries Pull Request resolved: pytorch#95065 Approved by: https://github.com/albanD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will be needed if one wants to make accurate XFAIL validation
I.e.
torch.backends.mps.is_macos13_or_newer()will return True if PyTorch is running on MacOS 13.0 or newer,torch.backends.mps.is_macos13_or_newer(1)will return True if running on MacOS 13.1 or newer andtorch.backends.mps.is_macos13_or_newer(2)will return True if running on MacOS 13.2 or newerDo not use 13.3 check as
@availabledoes not really work for shared libraries