[MPS] Add pow.Scalar #95201
Closed
[MPS] Add pow.Scalar #95201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95201
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3858a8a: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/mps
qqaatw
commented
Feb 21, 2023
Comment on lines
-9835
to
+10151
| elif (op.name in self.FP16_LOW_PRECISION_LIST) and dtype == torch.float16: | ||
| elif op.name in self.FP16_LOW_PRECISION_LIST and dtype == torch.float16: | ||
| atol = 1e-2 | ||
| rtol = 1e-2 | ||
| elif (op.name == "masked.mean"): | ||
| elif op.name == "masked.mean": | ||
| atol = 7e-4 | ||
| rtol = 2e-3 | ||
| elif (op.name == "native_layer_norm"): | ||
| elif op.name == "native_layer_norm": |
There was a problem hiding this comment.
Make them more pythonic and consistent
bdhirsh
added
the
triaged
|
@pytorchbot label "accept2run" |
kulinseth
approved these changes
Feb 27, 2023
pytorch-bot
bot
added
ciflow/trunk
qqaatw
force-pushed
the
add_pow_scalar_mm
branch
3 times, most recently
from
6c50dfa
to
66e2cc2
Compare
qqaatw
force-pushed
the
add_pow_scalar_mm
branch
from
66e2cc2
to
4155ac2
Compare
qqaatw
force-pushed
the
add_pow_scalar_mm
branch
from
1a8f4ff
to
a65dffd
Compare
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 2, 2023
1. Adds `pow.Scalar`. 2. Modifies testing `atol` and `rtol` to get pow output match tests pass. 3. Xfails numerically incorrect dtypes. Pull Request resolved: pytorch/pytorch#95201 Approved by: https://github.com/kulinseth
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 5, 2023
1. Adds `pow.Scalar`. 2. Modifies testing `atol` and `rtol` to get pow output match tests pass. 3. Xfails numerically incorrect dtypes. Pull Request resolved: pytorch/pytorch#95201 Approved by: https://github.com/kulinseth
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 5, 2023
1. Adds `pow.Scalar`. 2. Modifies testing `atol` and `rtol` to get pow output match tests pass. 3. Xfails numerically incorrect dtypes. Pull Request resolved: pytorch/pytorch#95201 Approved by: https://github.com/kulinseth
pruthvistony
added a commit
to ROCm/pytorch
that referenced
this pull request
May 2, 2023
This reverts commit f33180f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pow.Scalar.atolandrtolto get pow output match tests pass.