[Dynamo] No graph break on calling dict & collections.OrderedDict() #95250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95250
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit bf1d037: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jansel
approved these changes
Feb 22, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 23, 2023
…#95250) It's common to call ```dict()``` or ```collections.OrderedDict()``` inside of ```forward``` function, so we should not graph break. This pattern has been used in many places including: * The use case in [torchvision]( https://github.com/pytorch/vision/blob/928b05cad36eadb13e169f03028767c8bcd1f21d/torchvision/models/_utils.py#L66-L73). * It causes ~100 model failures(nopython=True) in the 14k github models. * Also it hits several Meta internal use cases. Pull Request resolved: pytorch/pytorch#95250 Approved by: https://github.com/jansel
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 23, 2023
…#95250) It's common to call ```dict()``` or ```collections.OrderedDict()``` inside of ```forward``` function, so we should not graph break. This pattern has been used in many places including: * The use case in [torchvision]( https://github.com/pytorch/vision/blob/928b05cad36eadb13e169f03028767c8bcd1f21d/torchvision/models/_utils.py#L66-L73). * It causes ~100 model failures(nopython=True) in the 14k github models. * Also it hits several Meta internal use cases. Pull Request resolved: pytorch/pytorch#95250 Approved by: https://github.com/jansel
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 23, 2023
…#95250) It's common to call ```dict()``` or ```collections.OrderedDict()``` inside of ```forward``` function, so we should not graph break. This pattern has been used in many places including: * The use case in [torchvision]( https://github.com/pytorch/vision/blob/928b05cad36eadb13e169f03028767c8bcd1f21d/torchvision/models/_utils.py#L66-L73). * It causes ~100 model failures(nopython=True) in the 14k github models. * Also it hits several Meta internal use cases. Pull Request resolved: pytorch/pytorch#95250 Approved by: https://github.com/jansel
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 25, 2023
…#95250) It's common to call ```dict()``` or ```collections.OrderedDict()``` inside of ```forward``` function, so we should not graph break. This pattern has been used in many places including: * The use case in [torchvision]( https://github.com/pytorch/vision/blob/928b05cad36eadb13e169f03028767c8bcd1f21d/torchvision/models/_utils.py#L66-L73). * It causes ~100 model failures(nopython=True) in the 14k github models. * Also it hits several Meta internal use cases. Pull Request resolved: pytorch/pytorch#95250 Approved by: https://github.com/jansel
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 25, 2023
…#95250) It's common to call ```dict()``` or ```collections.OrderedDict()``` inside of ```forward``` function, so we should not graph break. This pattern has been used in many places including: * The use case in [torchvision]( https://github.com/pytorch/vision/blob/928b05cad36eadb13e169f03028767c8bcd1f21d/torchvision/models/_utils.py#L66-L73). * It causes ~100 model failures(nopython=True) in the 14k github models. * Also it hits several Meta internal use cases. Pull Request resolved: pytorch/pytorch#95250 Approved by: https://github.com/jansel
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 1, 2023
Fixes OrderedDict reconstruction issue found in #95250 with an attempt to fix it here #95725 Pull Request resolved: #95800 Approved by: https://github.com/yanboliang, https://github.com/clee2000
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 2, 2023
Fixes OrderedDict reconstruction issue found in pytorch/pytorch#95250 with an attempt to fix it here pytorch/pytorch#95725 Pull Request resolved: pytorch/pytorch#95800 Approved by: https://github.com/yanboliang, https://github.com/clee2000
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 5, 2023
Fixes OrderedDict reconstruction issue found in pytorch/pytorch#95250 with an attempt to fix it here pytorch/pytorch#95725 Pull Request resolved: pytorch/pytorch#95800 Approved by: https://github.com/yanboliang, https://github.com/clee2000
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 5, 2023
…#95250) It's common to call ```dict()``` or ```collections.OrderedDict()``` inside of ```forward``` function, so we should not graph break. This pattern has been used in many places including: * The use case in [torchvision]( https://github.com/pytorch/vision/blob/928b05cad36eadb13e169f03028767c8bcd1f21d/torchvision/models/_utils.py#L66-L73). * It causes ~100 model failures(nopython=True) in the 14k github models. * Also it hits several Meta internal use cases. Pull Request resolved: pytorch/pytorch#95250 Approved by: https://github.com/jansel
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 5, 2023
Fixes OrderedDict reconstruction issue found in pytorch/pytorch#95250 with an attempt to fix it here pytorch/pytorch#95725 Pull Request resolved: pytorch/pytorch#95800 Approved by: https://github.com/yanboliang, https://github.com/clee2000
|
I found that in the test_tristandeleu_pytorch_meta.py of the 14k github models projects, there will still be cases calling OrderedDict() with iterators args leading to graph break. I want to know if the case is likely to be supported. And if so, what are the general ideas? |
I found it has been fixed by #96122, thank you! |
pruthvistony
added a commit
to ROCm/pytorch
that referenced
this pull request
May 2, 2023
…Dict() (pytorch#95250)" This reverts commit b5ff41a.
jhavukainen
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Mar 15, 2024
…ytorch#95250) It's common to call ```dict()``` or ```collections.OrderedDict()``` inside of ```forward``` function, so we should not graph break. This pattern has been used in many places including: * The use case in [torchvision]( https://github.com/pytorch/vision/blob/928b05cad36eadb13e169f03028767c8bcd1f21d/torchvision/models/_utils.py#L66-L73). * It causes ~100 model failures(nopython=True) in the 14k github models. * Also it hits several Meta internal use cases. Pull Request resolved: pytorch#95250 Approved by: https://github.com/jansel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's common to call
dict()orcollections.OrderedDict()inside offorwardfunction, so we should not graph break.This pattern has been used in many places including:
cc @soumith @voznesenskym @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @desertfire