Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DCP] Update DCP to use the updated FSDP optim state_dict APIs #95303

Closed
wants to merge 1 commit into from
Closed

[DCP] Update DCP to use the updated FSDP optim state_dict APIs #95303

wants to merge 1 commit into from

Conversation

wz337
Copy link
Contributor

@wz337 wz337 commented Feb 22, 2023

No description provided.

@pytorch-bot pytorch-bot bot added the release notes: distributed (fsdp) release notes category label Feb 22, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 22, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95303

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 4 Pending

As of commit 3821e4e:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@wz337
Copy link
Contributor Author

wz337 commented Feb 22, 2023

@pytorchmergebot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased update_FSDP_optim_state_dict_API onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout update_FSDP_optim_state_dict_API && git pull --rebase)

Copy link
Contributor

@fegin fegin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wz337
Copy link
Contributor Author

wz337 commented Feb 23, 2023

@pytorchmergebot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 23, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Feb 23, 2023
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Feb 23, 2023
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Feb 23, 2023
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Feb 25, 2023
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Feb 25, 2023
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 5, 2023
pruthvistony added a commit to ROCm/pytorch that referenced this pull request May 2, 2023
jhavukainen pushed a commit to kulinseth/pytorch that referenced this pull request Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants