Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deepcopy output node metadata #95426

Closed
wants to merge 1 commit into from
Closed

Deepcopy output node metadata #95426

wants to merge 1 commit into from

Conversation

angelayi
Copy link
Contributor

Fixes #ISSUE_NUMBER

@pytorch-bot pytorch-bot bot added the release notes: fx release notes category label Feb 24, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 24, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95426

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 0f29834:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

SherlockNoMad
SherlockNoMad reviewed Feb 24, 2023
View reviewed changes
torch/fx/graph.py
g.output(output_val, type_expr=getattr(old_output_val, 'type', None))
output_val, old_output_node = output_vals
new_output_node = g.output(output_val, type_expr=getattr(old_output_node, 'type', None))
new_output_node.meta = copy.copy(old_output_node.meta)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be done inside graph_copy.
see line 780

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that might break BC because the way graph_copy is implemented, it isn't meant to copy over the output node.

@angelayi
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 24, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot.

@angelayi
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot.

@angelayi
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 1, 2023
@angelayi @cyyever
Deepcopy output node metadata (#95426)
2ef1957 
Fixes #ISSUE_NUMBER

Pull Request resolved: pytorch/pytorch#95426
Approved by: https://github.com/SherlockNoMad
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 2, 2023
@angelayi @cyyever
Deepcopy output node metadata (#95426)
7c20e40 
Fixes #ISSUE_NUMBER

Pull Request resolved: pytorch/pytorch#95426
Approved by: https://github.com/SherlockNoMad
@msaroufim msaroufim mentioned this pull request Mar 3, 2023
Closed
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 5, 2023
@angelayi @cyyever
Deepcopy output node metadata (#95426)
847f559 
Fixes #ISSUE_NUMBER

Pull Request resolved: pytorch/pytorch#95426
Approved by: https://github.com/SherlockNoMad
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 5, 2023
@angelayi @cyyever
Deepcopy output node metadata (#95426)
141130c 
Fixes #ISSUE_NUMBER

Pull Request resolved: pytorch/pytorch#95426
Approved by: https://github.com/SherlockNoMad
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 27, 2023
@angelayi @cyyever
Deepcopy output node metadata (#95426)
20f991e 
Fixes #ISSUE_NUMBER

Pull Request resolved: pytorch/pytorch#95426
Approved by: https://github.com/SherlockNoMad
pruthvistony added a commit to ROCm/pytorch that referenced this pull request May 2, 2023
@pruthvistony
Revert "Deepcopy output node metadata (pytorch#95426)"
07050fb 
This reverts commit d301caa.
jhavukainen pushed a commit to kulinseth/pytorch that referenced this pull request Mar 15, 2024
@angelayi @jhavukainen
Deepcopy output node metadata (pytorch#95426)
2df4842 
Fixes #ISSUE_NUMBER

Pull Request resolved: pytorch#95426
Approved by: https://github.com/SherlockNoMad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SherlockNoMad SherlockNoMad SherlockNoMad approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: fx release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@angelayi @pytorchmergebot @SherlockNoMad