[quantization] Replace special characters in name with underscore in prepare_pt2e #95488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95488
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 83de436: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ydwu4
changed the title
|
dumb question: what if we have two scope path like and does this mean we will map them to the same scope path |
|
discarded as test is fixed internally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#94945 causes a internal test failure. The root cause is that during second tracing, the scope path we construct is not a valid attribute name due to the existence of special characters such as "()[],". We replace all of them with underscore here.