Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MPS] Fix views with 3 or more sliced dimensions #95762

Closed
wants to merge 1 commit into from
Closed

[MPS] Fix views with 3 or more sliced dimensions #95762

wants to merge 1 commit into from

Conversation

DenisVieriu97
Copy link
Collaborator

Fixes #95482

@DenisVieriu97 DenisVieriu97 added the ciflow/mps Run MPS tests (subset of trunk) label Mar 1, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 1, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95762

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a42b5ff:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: mps Release notes category label Mar 1, 2023
@kulinseth
Copy link
Collaborator

@pytorchbot merge -f "MPS tests are green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: PR #95762 has not been reviewed yet

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

razarmehr
razarmehr approved these changes Mar 1, 2023
View reviewed changes
Copy link
Collaborator

@razarmehr razarmehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@razarmehr
Copy link
Collaborator

@pytorchbot merge -f "MPS tests are green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 2, 2023
@DenisVieriu97 @cyyever
[MPS] Fix views with 3 or more sliced dimensions (#95762)
f711760 
Fixes pytorch/pytorch#95482
Pull Request resolved: pytorch/pytorch#95762
Approved by: https://github.com/razarmehr
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Mar 2, 2023
@DenisVieriu97 @kulinseth
[MPS] Fix views with 3 or more sliced dimensions (pytorch#95762)
7d1c0fb 
Fixes pytorch#95482
Pull Request resolved: pytorch#95762
Approved by: https://github.com/razarmehr
This was referenced Mar 2, 2023
Merged
Closed
malfet pushed a commit that referenced this pull request Mar 2, 2023
@kulinseth @DenisVieriu97
[MPS] Fix views with 3 or more sliced dimensions (#95762) (#95871)
82b078b 
Fixes #95482
Pull Request resolved: #95762
Approved by: https://github.com/razarmehr

Co-authored-by: Denis Vieriu <dvieriu@apple.com>
@msaroufim msaroufim mentioned this pull request Mar 3, 2023
Closed
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 5, 2023
@DenisVieriu97 @cyyever
[MPS] Fix views with 3 or more sliced dimensions (#95762)
eaa70d5 
Fixes pytorch/pytorch#95482
Pull Request resolved: pytorch/pytorch#95762
Approved by: https://github.com/razarmehr
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 5, 2023
@DenisVieriu97 @cyyever
[MPS] Fix views with 3 or more sliced dimensions (#95762)
aa8eb13 
Fixes pytorch/pytorch#95482
Pull Request resolved: pytorch/pytorch#95762
Approved by: https://github.com/razarmehr
pruthvistony added a commit to ROCm/pytorch that referenced this pull request May 2, 2023
@pruthvistony
Revert "[MPS] Fix views with 3 or more sliced dimensions (pytorch#95762…
4605bd8 
…)"

This reverts commit e5a959a.
pruthvistony pushed a commit to ROCm/pytorch that referenced this pull request May 3, 2023
@kulinseth @DenisVieriu97 @pruthvistony
[MPS] Fix views with 3 or more sliced dimensions (pytorch#95762) (pyt…
a8eea79 
…orch#95871)

Fixes pytorch#95482
Pull Request resolved: pytorch#95762
Approved by: https://github.com/razarmehr

Co-authored-by: Denis Vieriu <dvieriu@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razarmehr razarmehr razarmehr approved these changes

@kulinseth kulinseth Awaiting requested review from kulinseth

Assignees
No one assigned
Labels
ciflow/mps Run MPS tests (subset of trunk) Merged open source release notes: mps Release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calculation on tensor views fails on MPS - Placeholder shape mismatches
5 participants
@DenisVieriu97 @kulinseth @pytorchmergebot @razarmehr @pytorchbot