[MPS] Add fixes for div with floor and raise error for div_trunc #95769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95769
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3078c46: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/mps
kulinseth
commented
Mar 1, 2023
| @@ -10171,6 +10172,9 @@ def get_samples(): | |||
| self.assertEqual(cpu_out, mps_out, atol=atol, rtol=rtol) | |||
|
|
|||
| except Exception as e: | |||
| if any(s in str(e).lower() for s in ["float16", "div truc rounding"]): | |||
There was a problem hiding this comment.
This will be cleaned out when we move to XFAILLIST. It will be next PR, so I didn't want to spend time on moving it to xfaillist.
There was a problem hiding this comment.
I really hope this will be removed soon, as it essentially makes test results unpredicable and allows one to sneak any number of regressions under the hope
There was a problem hiding this comment.
Sure, as part of the XFAILLIST it will be removed.
DenisVieriu97
approved these changes
Mar 1, 2023
|
@pytorchbot merge -f "MPS tests are green" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 2, 2023
…769) Fixes #ISSUE_NUMBER Pull Request resolved: pytorch/pytorch#95769 Approved by: https://github.com/DenisVieriu97
kulinseth
added a commit
to kulinseth/pytorch
that referenced
this pull request
Mar 2, 2023
…orch#95769) Fixes #ISSUE_NUMBER Pull Request resolved: pytorch#95769 Approved by: https://github.com/DenisVieriu97
kulinseth
added a commit
to kulinseth/pytorch
that referenced
this pull request
Mar 2, 2023
…orch#95769) Fixes #ISSUE_NUMBER Pull Request resolved: pytorch#95769 Approved by: https://github.com/DenisVieriu97
kulinseth
added a commit
to kulinseth/pytorch
that referenced
this pull request
Mar 2, 2023
…orch#95769) Fixes #ISSUE_NUMBER Pull Request resolved: pytorch#95769 Approved by: https://github.com/DenisVieriu97
This was referenced Mar 2, 2023
malfet
pushed a commit
that referenced
this pull request
Mar 2, 2023
* [MPS] Add fixes for div with floor and raise error for div_trunc (#95769) Fixes #ISSUE_NUMBER Pull Request resolved: #95769 Approved by: https://github.com/DenisVieriu97 * Add back the unittest skip for MacOS 12.
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 5, 2023
…769) Fixes #ISSUE_NUMBER Pull Request resolved: pytorch/pytorch#95769 Approved by: https://github.com/DenisVieriu97
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 5, 2023
…769) Fixes #ISSUE_NUMBER Pull Request resolved: pytorch/pytorch#95769 Approved by: https://github.com/DenisVieriu97
skotapati
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Apr 3, 2023
…orch#95769) Fixes #ISSUE_NUMBER Pull Request resolved: pytorch#95769 Approved by: https://github.com/DenisVieriu97
skotapati
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Apr 6, 2023
…orch#95769) Fixes #ISSUE_NUMBER Pull Request resolved: pytorch#95769 Approved by: https://github.com/DenisVieriu97
skotapati
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Apr 7, 2023
…orch#95769) Fixes #ISSUE_NUMBER Pull Request resolved: pytorch#95769 Approved by: https://github.com/DenisVieriu97
pruthvistony
pushed a commit
to ROCm/pytorch
that referenced
this pull request
May 3, 2023
* [MPS] Add fixes for div with floor and raise error for div_trunc (pytorch#95769) Fixes #ISSUE_NUMBER Pull Request resolved: pytorch#95769 Approved by: https://github.com/DenisVieriu97 * Add back the unittest skip for MacOS 12.
jhavukainen
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Mar 15, 2024
…orch#95769) Fixes #ISSUE_NUMBER Pull Request resolved: pytorch#95769 Approved by: https://github.com/DenisVieriu97
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #ISSUE_NUMBER