[optim] Widen the cases for defaulting to foreach #95818
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
janeyx99
added a commit
that referenced
this pull request
Mar 1, 2023
ghstack-source-id: 934a3c9f6df4198c2403f57a60d294c84ffb0472 Pull Request resolved: #95818
janeyx99
added
ciflow/trunk
Also added a test to verify the defaulting was as expected. [ghstack-poisoned]
janeyx99
added a commit
that referenced
this pull request
Mar 1, 2023
ghstack-source-id: 78b644d04475cb4845eaf5b608dc50bb47bdbbd0 Pull Request resolved: #95818
|
Closing in favor of #95820, I accidentally did a reset --soft instead of a rebase -i |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added a test to verify the defaulting was as expected.
Stack from ghstack (oldest at bottom):