Add flop formulas for sdpa #95854
Closed
Add flop formulas for sdpa #95854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95854
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e9e9c34: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Chillee
added a commit
that referenced
this pull request
Mar 2, 2023
ghstack-source-id: 771ea7fb25103fdfee0bf063b96f9b28aa2627aa Pull Request resolved: #95854
github-actions
bot
requested review from
albanD,
antoniojkim,
bdhirsh,
ezyang,
jbschlosser,
miladm,
SherlockNoMad,
voznesenskym and
wconstab
[ghstack-poisoned]
albanD
reviewed
Mar 2, 2023
[ghstack-poisoned]
[ghstack-poisoned]
drisspg
reviewed
Mar 3, 2023
| # [b, h, s, d] @ [b, h, d, s2] -> [b, h, s, s2] | ||
| total_flops += bmm_flop([(b * h, s, d), (b * h, d, s2)]) | ||
| # [b, h, s, s2] @ [b, h, s2, d] -> [b, h, s2, d] | ||
| total_flops += bmm_flop([(b * h, s, s2), (b * h, s2, d)]) |
There was a problem hiding this comment.
Not sure how precise flop_counting is but in essence, we only really care about the bmms right?
drisspg
approved these changes
Mar 3, 2023
|
I still need to add the backwards formulas, but I'll leave that to a future PR 🤔 |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 5, 2023
Pull Request resolved: pytorch/pytorch#95854 Approved by: https://github.com/drisspg
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 5, 2023
Pull Request resolved: pytorch/pytorch#95854 Approved by: https://github.com/drisspg
ydwu4
pushed a commit
to ydwu4/pytorch
that referenced
this pull request
Mar 10, 2023
Pull Request resolved: pytorch#95854 Approved by: https://github.com/drisspg
ydwu4
added a commit
to ydwu4/pytorch
that referenced
this pull request
Mar 13, 2023
Pull Request resolved: pytorch#95854 Approved by: https://github.com/drisspg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):