[DTensor][Shampoo] add _tenso.zero function #95863
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minddrummer
requested review from
mrshenli,
zhaojuanmao,
rohan-varma,
H-Huang,
awgu,
kwen2501,
wanchaol and
fegin
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95863
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9431180: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
|
|
This pull request was exported from Phabricator. Differential Revision: D43630718 |
minddrummer
added a commit
to minddrummer/pytorch
that referenced
this pull request
Mar 2, 2023
Summary: Pull Request resolved: pytorch#95863 implement zeros function inside DTensor API - user specify the zeros tensor shape, and the function will create local zero tensor given the placement information Test Plan: {F889157756} - unit test for util function for compute_local_tensor_size - unit test for _tensor.zeros Reviewed By: wanchaol Differential Revision: D43630718 fbshipit-source-id: 893578b7eb0e3993a24a2f4c5ae0ffc7713c70e2
minddrummer
force-pushed
the
export-D43630718
branch
from
d1af449
to
600429b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D43630718 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D43630718 |
minddrummer
added a commit
to minddrummer/pytorch
that referenced
this pull request
Mar 2, 2023
Summary: Pull Request resolved: pytorch#95863 implement zeros function inside DTensor API - user specify the zeros tensor shape, and the function will create local zero tensor given the placement information Test Plan: {F889157756} - unit test for util function for compute_local_tensor_size - unit test for _tensor.zeros Reviewed By: wanchaol Differential Revision: D43630718 fbshipit-source-id: 14b40863b40df696bc87a92166953f5ba2c5425d
minddrummer
force-pushed
the
export-D43630718
branch
from
600429b
to
7760204
Compare
minddrummer
added a commit
to minddrummer/pytorch
that referenced
this pull request
Mar 2, 2023
Summary: Pull Request resolved: pytorch#95863 implement zeros function inside DTensor API - user specify the zeros tensor shape, and the function will create local zero tensor given the placement information Test Plan: {F889157756} - unit test for util function for compute_local_tensor_size - unit test for _tensor.zeros Reviewed By: wanchaol Differential Revision: D43630718 fbshipit-source-id: 85adfdf0f2c6f5e2fcbc9df84e90e8d6abc7d2c5
minddrummer
force-pushed
the
export-D43630718
branch
from
7760204
to
51e1778
Compare
|
This pull request was exported from Phabricator. Differential Revision: D43630718 |
|
/easycla |
|
This pull request was exported from Phabricator. Differential Revision: D43630718 |
minddrummer
force-pushed
the
export-D43630718
branch
from
51e1778
to
01e6e85
Compare
minddrummer
added a commit
to minddrummer/pytorch
that referenced
this pull request
Mar 3, 2023
Summary: Pull Request resolved: pytorch#95863 implement zeros function inside DTensor API - user specify the zeros tensor shape, and the function will create local zero tensor given the placement information Test Plan: {F889157756} - unit test for util function for compute_local_tensor_size - unit test for _tensor.zeros Reviewed By: wanchaol Differential Revision: D43630718 fbshipit-source-id: d9406f30c2bd5919cbc63f398d66e10de43248d6
|
@pytorchbot merge -f |
|
❌ 🤖 pytorchbot command failed: Try |
|
This pull request was exported from Phabricator. Differential Revision: D43630718 |
minddrummer
added a commit
to minddrummer/pytorch
that referenced
this pull request
Mar 3, 2023
Summary: Pull Request resolved: pytorch#95863 implement zeros function inside DTensor API - user specify the zeros tensor shape, and the function will create local zero tensor given the placement information Test Plan: {F889157756} - unit test for util function for compute_local_tensor_size - unit test for _tensor.zeros Reviewed By: wanchaol Differential Revision: D43630718 fbshipit-source-id: 341ecb2940ca1f5d4cebfc0fd69abe09c5c9959d
minddrummer
force-pushed
the
export-D43630718
branch
from
01e6e85
to
f30b011
Compare
Summary: Pull Request resolved: pytorch#95863 implement zeros function inside DTensor API - user specify the zeros tensor shape, and the function will create local zero tensor given the placement information Test Plan: {F889157756} - unit test for util function for compute_local_tensor_size - unit test for _tensor.zeros Reviewed By: wanchaol Differential Revision: D43630718 fbshipit-source-id: a2564cce961f898089f946245eac550db5f8d20b
|
This pull request was exported from Phabricator. Differential Revision: D43630718 |
minddrummer
force-pushed
the
export-D43630718
branch
from
f30b011
to
9431180
Compare
|
@pytorchbot merge -f 'Landed internally' (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 5, 2023
Summary:
implement zeros function inside DTensor API
- user specify the zeros tensor shape, and the function will create local zero tensor given the placement information
Test Plan:
{F889157756} - unit test for util function for compute_local_tensor_size
- unit test for _tensor.zeros
Reviewed By: wanchaol
Differential Revision: D43630718
Pull Request resolved: pytorch/pytorch#95863
Approved by: https://github.com/wanchaol
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 5, 2023
Summary:
implement zeros function inside DTensor API
- user specify the zeros tensor shape, and the function will create local zero tensor given the placement information
Test Plan:
{F889157756} - unit test for util function for compute_local_tensor_size
- unit test for _tensor.zeros
Reviewed By: wanchaol
Differential Revision: D43630718
Pull Request resolved: pytorch/pytorch#95863
Approved by: https://github.com/wanchaol
ydwu4
pushed a commit
to ydwu4/pytorch
that referenced
this pull request
Mar 10, 2023
Summary:
implement zeros function inside DTensor API
- user specify the zeros tensor shape, and the function will create local zero tensor given the placement information
Test Plan:
{F889157756} - unit test for util function for compute_local_tensor_size
- unit test for _tensor.zeros
Reviewed By: wanchaol
Differential Revision: D43630718
Pull Request resolved: pytorch#95863
Approved by: https://github.com/wanchaol
ydwu4
added a commit
to ydwu4/pytorch
that referenced
this pull request
Mar 13, 2023
Summary:
implement zeros function inside DTensor API
- user specify the zeros tensor shape, and the function will create local zero tensor given the placement information
Test Plan:
{F889157756} - unit test for util function for compute_local_tensor_size
- unit test for _tensor.zeros
Reviewed By: wanchaol
Differential Revision: D43630718
Pull Request resolved: pytorch#95863
Approved by: https://github.com/wanchaol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
implement zeros function inside DTensor API
Test Plan:
{F889157756} - unit test for util function for compute_local_tensor_size
Reviewed By: wanchaol
Differential Revision: D43630718