Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix node provenance tracking #95901

Closed
wants to merge 6 commits into from
Closed

Fix node provenance tracking #95901

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0095ad2
Fix node provenance tracking
Chillee Mar 2, 2023
24dfafe
Update on "Fix node provenance tracking"
Chillee Mar 2, 2023
b9a7407
Update on "Fix node provenance tracking"
Chillee Mar 2, 2023
db335ad
Update on "Fix node provenance tracking"
Chillee Mar 2, 2023
6f3c63d
Update on "Fix node provenance tracking"
Chillee Mar 3, 2023
d26cdcf
Update on "Fix node provenance tracking"
Chillee Mar 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 6 additions & 2 deletions torch/_inductor/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,10 +238,14 @@ def get_fused_kernel_name(node_schedule):
def gather_origins(args, kwargs):
import itertools

from .ir import ComputedBuffer, IRNode
from . import ir

def is_unrealized_node(n):
return isinstance(n, IRNode) and not isinstance(n, ComputedBuffer)
if isinstance(n, ir.TensorBox):
return is_unrealized_node(n.data)
if isinstance(n, ir.StorageBox):
return is_unrealized_node(n.data)
return isinstance(n, ir.IRNode) and isinstance(n, ir.Pointwise)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we only test Pointwise here; shouldn't Reduction also count?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, but Reductions are always materialized during lowering phase.


kwarg_origins = [val.origins for val in kwargs.values() if is_unrealized_node(val)]
arg_origins = [arg.origins for arg in args if is_unrealized_node(arg)]
Expand Down